-
Notifications
You must be signed in to change notification settings - Fork 226
Open
Labels
C-segmentationComponent: SegmentationComponent: SegmentationS-tinySize: Less than an hour (trivial fixes)Size: Less than an hour (trivial fixes)T-docs-testsType: Code change outside core libraryType: Code change outside core librarymilestone-non-blockingThese issues are in a milestone, but do not block the milestone (and can be removed if necessary)These issues are in a milestone, but do not block the milestone (and can be removed if necessary)
Milestone
Description
Word and Sentence segmenters have two versions of the options: one with a content_locale
and the other without. The reason for the split is that the locale version can return a DataError.
It seems most/all of our examples use the InvariantOptions. When opening the docs page for either options struct, there is no clear explanation about why you would want to use each one. It also does not clearly explain that the InvariantOptions go to the constructor called new
and the Options go to the one called try_new
.
CC @sven-oly
Metadata
Metadata
Assignees
Labels
C-segmentationComponent: SegmentationComponent: SegmentationS-tinySize: Less than an hour (trivial fixes)Size: Less than an hour (trivial fixes)T-docs-testsType: Code change outside core libraryType: Code change outside core librarymilestone-non-blockingThese issues are in a milestone, but do not block the milestone (and can be removed if necessary)These issues are in a milestone, but do not block the milestone (and can be removed if necessary)