Skip to content

Use Duckscript functions in Makefile.toml #785

Open
@sffc

Description

@sffc

In the WASM and Valgrind CI tools, we have some boilerplate that should be able to be refactored more cleanly into a Duckscript function.

Also, the way we loop over examples is better in Valgrind than in WASM, and we should use the Valgrind approach for both.

Suggested task list:

  • Review the documentation for cargo make, the Duckscript language, and the Duckscript SDK.
  • Review how our Makefile.toml currently works, including the imports from /tools/scripts, keeping an eye out for areas where we could reduce duplication or make things more efficient.
  • Create a new Duckscript file to contain shared functions/routines.
  • Refactor the code from valgrind.toml into a function called something like for_each_example that runs a loop over all examples.
  • Re-write the wasm-wasm-dev and wasm-wasm-release tasks in wasm.toml using the new for_each_example function.
  • Also in wasm.toml, refactor the loops in wasm-wat, wasm-dcmp, wasm-opt, and wasm-twiggy-dominators to use new function named something like for_each_stale_wasm.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-processComponent: Team processesS-smallSize: One afternoon (small bug fix or enhancement)T-techdebtType: ICU4X code health and tech debtgood first issueGood for newcomershelp wantedIssue needs an assignee

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions