chore(lint): Format with goimports, enforce go mod tidy (salesforce#247)

* chore(lint): Format with goimports

* chore(lint): Install goimports to avoid go.sum requirement

* chore(lint): Enforce goimports formatting and go mod tidy

* chore(ci): Remove Travis CI file, GHA used now

Author: kskewes-sf

.github/workflows/test.yml

@@ -24,12 +24,12 @@ jobs:
           go-version-file: go.mod
 
       - name: Format with goimports
-        # TODO: Enforce when possible.
         run: |
-          if [ "$(go run golang.org/x/tools/cmd/goimports -l --format-only . | wc -l)" -gt 0 ];
+          go install golang.org/x/tools/cmd/goimports@latest
+          if [ "$(goimports -l --format-only . | wc -l)" -gt 0 ];
              then
-             go run golang.org/x/tools/cmd/goimports -l --format-only .
-             exit 0
+             goimports -l --format-only .
+             exit 1
           fi
 
       - name: Run go vet
@@ -42,10 +42,9 @@ jobs:
           go test -v -race ./...
 
       - name: Run go mod tidy
-        # TODO: Enforce when possible.
         run: |
           go mod tidy
-          git diff --exit-code -- go.mod go.sum || true
+          git diff --exit-code -- go.mod go.sum
 
       - name: Run go build
         run: go build ./pkg/sloop/main.go

.travis.yml

@@ -1,10 +1,11 @@
 package common
 
 import (
+	"testing"
+
 	"github.com/dgraph-io/badger/v2"
 	"github.com/salesforce/sloop/pkg/sloop/store/untyped/badgerwrap"
 	"github.com/stretchr/testify/assert"
-	"testing"
 )
 
 var commonPrefix = "/commonprefix/001546405200/"

pkg/sloop/common/db_utilities_test.go

@@ -1,10 +1,11 @@
 package common
 
 import (
+	"sort"
+
 	"github.com/dgraph-io/badger/v2"
 	"github.com/golang/glog"
 	"github.com/salesforce/sloop/pkg/sloop/store/untyped/badgerwrap"
-	"sort"
 )
 
 type SloopKey struct {

pkg/sloop/common/partition_utilities.go

@@ -2,9 +2,10 @@ package common
 
 import (
 	"fmt"
-	"github.com/stretchr/testify/assert"
 	"path"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
 )
 
 var files = []string{"webfiles/index.html", "webfiles/debug.html", "webfiles/filter.js", "webfiles/sloop.cs"}

pkg/sloop/common/utilities_test.go

@@ -8,10 +8,11 @@
 package ingress
 
 import (
+	"io/ioutil"
+
 	"github.com/ghodss/yaml"
 	"github.com/golang/glog"
 	"github.com/salesforce/sloop/pkg/sloop/store/typed"
-	"io/ioutil"
 )
 
 func PlayFile(outChan chan typed.KubeWatchResult, filename string) error {

pkg/sloop/ingress/fileplayback.go

@@ -8,11 +8,12 @@
 package ingress
 
 import (
+	"io/ioutil"
+	"sync"
+
 	"github.com/ghodss/yaml"
 	"github.com/golang/glog"
 	"github.com/salesforce/sloop/pkg/sloop/store/typed"
-	"io/ioutil"
-	"sync"
 )
 
 type FileRecorder struct {

pkg/sloop/ingress/filerecorder.go

@@ -1,11 +1,12 @@
 package ingress
 
 import (
+	"testing"
+
 	"github.com/stretchr/testify/assert"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/clientcmd"
 	"k8s.io/client-go/tools/clientcmd/api"
-	"testing"
 )
 
 func TestGetKubernetesContext(t *testing.T) {

pkg/sloop/ingress/kubeclient_test.go

@@ -10,9 +10,10 @@ package kubeextractor
 import (
 	"encoding/json"
 	"fmt"
-	"github.com/golang/glog"
 	"strings"
 	"time"
+
+	"github.com/golang/glog"
 )
 
 // Example Event

pkg/sloop/kubeextractor/events.go

@@ -8,9 +8,10 @@
 package kubeextractor
 
 import (
-	"github.com/stretchr/testify/assert"
 	"testing"
 	"time"
+
+	"github.com/stretchr/testify/assert"
 )
 
 func Test_ExtractInvolvedObject_OutputCorrect(t *testing.T) {