Add application to V2 application form relationships (#501)

* fix: application relationship for form v2

* 1.2.4

* fix: test fixes

Author: YegorZh

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@unit-finance/unit-node-sdk",
-  "version": "1.2.3",
+  "version": "1.2.4",
   "description": "",
   "main": "dist/unit.js",
   "types": "dist/unit.d.ts",

package.json

@@ -1,4 +1,4 @@
-import {BaseListParams, UnitConfig, UnitResponse, NoContent, Tags} from "../types/common"
+import {BaseListParams, UnitConfig, UnitResponse, Tags} from "../types/common"
 import { AchCounterparty, CounterpartyBalance, CreateCounterpartyRequest, PatchCounterpartyRequest } from "../types/counterparty"
 import { BaseResource } from "./baseResource"
 
@@ -12,8 +12,8 @@ export class Counterparties extends BaseResource {
         return await this.httpPost<UnitResponse<AchCounterparty>>("", { data: request })
     }
 
-    public async delete(id: string): Promise<NoContent> {
-        return await this.httpDelete<NoContent>(`/${id}`)
+    public async delete(id: string): Promise<UnitResponse<AchCounterparty>> {
+        return await this.httpDelete<UnitResponse<AchCounterparty>>(`/${id}`)
     }
 
     public async get(id: string): Promise<UnitResponse<AchCounterparty>> {

resources/counterparty.ts

@@ -535,9 +535,11 @@ describe("Business Applications", () => {
           expect(req.type).toBe("businessApplication")
     })
 
-    test("Simulation UpdateBusinessApplicationRequest - test structure", () => {
+    test("Simulation UpdateBusinessApplicationRequest - test structure", async () => {
+        const res = await createBusinessApplication(unit)
+
         const req: PatchApplicationRequest = {
-            applicationId: "123",
+            applicationId: res.data.id,
             data: {
                 "type": "businessApplication",
                 "attributes": {
@@ -627,7 +629,6 @@ describe("Business Applications", () => {
 
     test("Test UpdateBusinessApplicationRequest - Update website", async () => {
         const res = await createBusinessApplication(unit)
-        expect(res.data.type).toBe("businessApplication")
 
         const attributes: PatchBusinessApplicationAttributes = {
           website: "https://www.piedpiper.com"

tests/applications.spec.ts

@@ -62,7 +62,7 @@ describe("Delete Counterparty", () => {
         const res = await unit.counterparties.get(createRes.data.id)
         expect(res.data.type === "achCounterparty").toBeTruthy()
         const deleteRes = await unit.counterparties.delete(res.data.id)
-        expect(deleteRes === "").toBeTruthy() // NoContent
+        expect(deleteRes.data.type === "achCounterparty").toBeTruthy()
     })
 })
 

tests/counterparties.spec.ts

@@ -8,11 +8,11 @@ const unit = new Unit(process.env.UNIT_TOKEN || "test", process.env.UNIT_API_URL
 
 describe("Get Credit Applications", () => {
     test("Test Get endpoint", async () => {
-        const res = await unit.creditApplications.list()
+        const res = await unit.creditApplications.list({limit: 20})
         expect(res.data).toBeInstanceOf(Array)
         res.data.forEach(async element => {
             expect(element.type).toContain("CreditApplication")
-            const app = await (await unit.creditApplications.get(element.id)).data
+            const app = (await unit.creditApplications.get(element.id)).data
             expect(element.type).toBe(app.type)
             expect(element.id).toBe(app.id)
         })

tests/creditApplications.spec.ts

@@ -174,6 +174,12 @@ export type ApplicationFormV2 = {
             href: string
         }
     }
+    relationships?: {
+        /**
+         * The application.
+         */
+        application?: Relationship
+    }
 }