Include param and export bookPayment (#170)

* fix include param to get method

* fix lint warning

* fix lint warning

* export bookPayment interface

Author: axshani

resources/payments.ts

@@ -27,7 +27,7 @@ export class Payments extends BaseResource {
      * Related resources include: customer, account, transaction. See Getting Related Resources
      */
     public async get(id: string, include?: string): Promise<UnitResponse<Payment & Include<Account[] | Customer[] | Transaction[]>>> {
-        const params = { include: include ? `include=${include}` : "" }
+        const params = {...(include && { include })}
         return this.httpGet<UnitResponse<Payment & Include<Account[] | Customer[] | Transaction[]>>>(`/${id}`, { params })
     }
 

resources/receivedPayments.ts

@@ -24,7 +24,7 @@ export class ReceivedPayments extends BaseResource {
      * Related resources include: customer, account. See Getting Related Resources
      */
     public async get(id: string, include?: string): Promise<UnitResponse<AchReceivedPayment & Include<Account[] | Customer[]>>> {
-        const params = { include: include ? `include=${include}` : "" }
+        const params = {...(include && { include })}
         return this.httpGet<UnitResponse<AchReceivedPayment & Include<Account[] | Customer[]>>>(`/${id}`, { params })
     }
 

resources/rewards.ts

@@ -17,7 +17,7 @@ export class Rewards extends BaseResource {
      * Related resources include: customer, account, transaction. See [Getting Related Resources](https://developers.unit.co/about-jsonapi/#intro-getting-related-resources)
      */
     public async get(id: string, include?: string): Promise<UnitResponse<Reward & Include<Account[] | Customer[] | Transaction[]>>> {
-        const params = { include: include ? `include=${include}` : "" }
+        const params = {...(include && { include })}
         return this.httpGet<UnitResponse<Reward & Include<Account[] | Customer[] | Transaction[]>>>(`/${id}`, { params })
     }
 

resources/transactions.ts

@@ -22,7 +22,7 @@ export class Transactions extends BaseResource {
     public async get(accountId: string, transactionId: string, customerId?: string, include?: string): Promise<UnitResponse<Transaction> & Include<Account[] | Customer[]>> {
         const parameters = {
             ...(customerId && { "filter[customerId]": customerId }),
-            "include": include ? include : ""
+            ...(include && { include })
         }
 
         return await this.httpGet<UnitResponse<Transaction> & Include<Account[] | Customer[]>>(`/accounts/${accountId}/transactions/${transactionId}`, { params: parameters })

tests/payments.spec.ts

@@ -1,6 +1,6 @@
-import { CreateBookPaymentRequest, CreateLinkedPaymentRequest, Unit } from "../unit"
+import { CreateBookPaymentRequest, Unit } from "../unit" //CreateLinkedPaymentRequest
 import { createIndividualAccount } from "./accounts.spec"
-import { createCounterpartyForTest } from "./counterparties.spec"
+// import { createCounterpartyForTest } from "./counterparties.spec"
 
 import dotenv from "dotenv"
 dotenv.config()
@@ -60,32 +60,32 @@ describe("Create BookPayment", () => {
     })
 })
 
-async function createPayment() : Promise<CreateLinkedPaymentRequest> {
-    const createCounterpartRes = await createCounterpartyForTest("22603")
+// async function createPayment() : Promise<CreateLinkedPaymentRequest> {
+//     const createCounterpartRes = await createCounterpartyForTest("22603")
 
-    return {
-            "type": "achPayment",
-            "attributes": {
-                "amount": 200,
-                "direction": "Debit",
-                "description": "ACH PYMT"
-            },
-            "relationships": {
-                "account": {
-                    "data": {
-                        "type": "depositAccount",
-                        "id": "27573"
-                    }
-                },
-                "counterparty": {
-                    "data": {
-                        "type": "counterparty",
-                        "id": createCounterpartRes.data.id
-                    }
-                }
-            }
-    }
-}
+//     return {
+//             "type": "achPayment",
+//             "attributes": {
+//                 "amount": 200,
+//                 "direction": "Debit",
+//                 "description": "ACH PYMT"
+//             },
+//             "relationships": {
+//                 "account": {
+//                     "data": {
+//                         "type": "depositAccount",
+//                         "id": "27573"
+//                     }
+//                 },
+//                 "counterparty": {
+//                     "data": {
+//                         "type": "counterparty",
+//                         "id": createCounterpartRes.data.id
+//                     }
+//                 }
+//             }
+//     }
+// }
 
 // describe("Create LinkedPayment", () => {
 //     test("create linked payment", async () => {

types/payments.ts

@@ -108,7 +108,7 @@ export interface AchPayment {
     } & BasePaymentRelationships
 }
 
-interface BookPayment {
+export interface BookPayment {
     /**
      * 	Identifier of the book payment resource.
      */