JSON.stringify(params.tags) (#419)

axshani · web-flow · commit c6c7d7e1c96a · 2023-12-14T16:23:11.000+02:00
diff --git a/resources/account.ts b/resources/account.ts
@@ -52,7 +52,7 @@ export class Accounts extends BaseResource {
             "page[limit]": (params?.limit ? params.limit : 100),
             "page[offset]": (params?.offset ? params.offset : 0),
             ...(params?.customerId && {"filter[customerId]": params.customerId}),
-            ...(params?.tags && {"filter[tags]": params.tags}),
+            ...(params?.tags && {"filter[tags]": JSON.stringify(params.tags)}),
             ...(params?.include && {"include": params.include}),
             ...(params?.fromBalance && {"filter[fromBalance]": params.fromBalance}),
             ...(params?.toBalance && {"filter[toBalance]": params.toBalance}),
diff --git a/resources/application.ts b/resources/application.ts
@@ -17,7 +17,7 @@ export class Applications extends BaseResource {
             "page[offset]": (params?.offset ? params?.offset : 0),
             ...(params?.query && { "filter[query]": params?.query }),
             ...(params?.email && { "filter[email]": params?.email }),
-            ...(params?.tags && { "filter[tags]": params?.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             "sort": params?.sort ? params.sort : "-createdAt"
         }
 
diff --git a/resources/applicationForm.ts b/resources/applicationForm.ts
@@ -20,7 +20,7 @@ export class ApplicationForms extends BaseResource {
         const parameters = {
             "page[limit]": (params?.limit ? params?.limit : 100),
             "page[offset]": (params?.offset ? params?.offset : 0),
-            ...(params?.tags && { "filter[tags]": params?.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             ...(params?.sort && { "sort": params.sort })
         }
         return this.httpGet<UnitResponse<ApplicationForm[]>>("", { params: parameters })
diff --git a/resources/cards.ts b/resources/cards.ts
@@ -70,7 +70,7 @@ export class Cards extends BaseResource {
             ...(params?.accountId && { "filter[accountId]": params.accountId }),
             ...(params?.customerId && { "filter[customerId]": params.customerId }),
             ...(params?.include && { "include": params.include }),
-            ...(params?.tags && { "filter[tags]": params?.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             "sort": params?.sort ? params.sort : "-createdAt"
         }
 
diff --git a/resources/chargeback.ts b/resources/chargeback.ts
@@ -32,7 +32,7 @@ export class Chargebacks extends BaseResource {
             ...(params?.customerId && {"filter[customerId]": params.customerId}),
             ...(params?.since && {"filter[since]": params.since}),
             ...(params?.until && {"filter[until]": params.until}),
-            ...(params?.tags && {"filter[tags]": params.tags}),
+            ...(params?.tags && {"filter[tags]": JSON.stringify(params.tags)}),
             ...(params?.include && {"include": params.include}),
             ...(params?.sort && {"sort": params.sort})
         }
diff --git a/resources/checkDeposit.ts b/resources/checkDeposit.ts
@@ -16,7 +16,7 @@ export class CheckDeposits extends BaseResource {
             "page[offset]": (params?.offset ? params.offset : 0),
             ...(params?.accountId && { "filter[accountId]": params.accountId }),
             ...(params?.customerId && { "filter[customerId]": params.customerId }),
-            ...(params?.tags && { "filter[tags]": params.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             "sort": params?.sort ? params.sort : "-createdAt",
             "include": params?.include ? params.include : "include"
         }
diff --git a/resources/counterparty.ts b/resources/counterparty.ts
@@ -1,4 +1,4 @@
-import {BaseListParams, UnitConfig, UnitResponse, NoContent} from "../types/common"
+import {BaseListParams, UnitConfig, UnitResponse, NoContent, Tags} from "../types/common"
 import { AchCounterparty, CounterpartyBalance, CreateCounterpartyRequest, PatchCounterpartyRequest } from "../types/counterparty"
 import { BaseResource } from "./baseResource"
 
@@ -25,7 +25,7 @@ export class Counterparties extends BaseResource {
             "page[limit]": (params?.limit ? params?.limit : 100),
             "page[offset]": (params?.offset ? params?.offset : 0),
             ...(params?.customerId && { "filter[customerId]": params?.customerId }),
-            ...(params?.tags && { "filter[tags]": params?.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
         }
 
         return this.httpGet<UnitResponse<AchCounterparty[]>>("", { params: parameters })
@@ -55,5 +55,5 @@ export interface CounterpartyListParams extends BaseListParams {
     /**
      * Optional. Filter Counterparties by Tags.
      */
-    tags?: object
+    tags?: Tags
 }
diff --git a/resources/customer.ts b/resources/customer.ts
@@ -23,7 +23,7 @@ export class Customers extends BaseResource {
             "page[offset]": (params?.offset ? params.offset : 0),
             ...(params?.query && { "filter[query]": params.query }),
             ...(params?.email && { "filter[email]": params.email }),
-            ...(params?.tags && { "filter[tags]": params.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             "sort": params?.sort ? params.sort : "-createdAt"
         }
 
diff --git a/resources/payments.ts b/resources/payments.ts
@@ -41,7 +41,7 @@ export class Payments extends BaseResource {
             "page[offset]": (params?.offset ? params.offset : 0),
             ...(params?.accountId && { "filter[accountId]": params.accountId }),
             ...(params?.customerId && { "filter[customerId]": params.customerId }),
-            ...(params?.tags && { "filter[tags]": params.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             ...(params?.since && { "filter[since]": params.since }),
             ...(params?.until && { "filter[until]": params.until }),
             ...(params?.counterpartyAccountId && { "filter[counterpartyAccountId]": params.counterpartyAccountId }),
diff --git a/resources/receivedPayments.ts b/resources/receivedPayments.ts
@@ -34,7 +34,7 @@ export class ReceivedPayments extends BaseResource {
             "page[offset]": (params?.offset ? params.offset : 0),
             ...(params?.accountId && { "filter[accountId]": params.accountId }),
             ...(params?.customerId && { "filter[customerId]": params.customerId }),
-            ...(params?.tags && { "filter[tags]": params.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             ...(params?.includeCompleted && { "filter[includeCompleted]": params.includeCompleted }),
             "sort": params?.sort ? params.sort : "-createdAt",
             "include": params?.include ? params.include : ""
diff --git a/resources/recurringPayments.ts b/resources/recurringPayments.ts
@@ -45,7 +45,7 @@ export class RecurringPayments extends BaseResource {
             "page[offset]": (params?.offset ? params.offset : 0),
             ...(params?.accountId && { "filter[accountId]": params.accountId }),
             ...(params?.customerId && { "filter[customerId]": params.customerId }),
-            ...(params?.tags && { "filter[tags]": params.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             ...(params?.fromStartTime && { "filter[fromStartTime]": params.fromStartTime }),
             ...(params?.toStartTime && { "filter[toStartTime]": params.toStartTime }),
             ...(params?.fromEndTime && { "filter[fromEndTime]": params.fromEndTime }),
diff --git a/resources/rewards.ts b/resources/rewards.ts
@@ -30,7 +30,7 @@ export class Rewards extends BaseResource {
             ...(params?.receivingAccountId && { "filter[receivingAccountId]": params.receivingAccountId }),
             ...(params?.customerId && { "filter[customerId]": params.customerId }),
             ...(params?.cardId && { "filter[cardId]": params.cardId }),
-            ...(params?.tags && { "filter[tags]": params.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             ...(params?.since && { "filter[since]": params.since }),
             ...(params?.until && { "filter[until]": params.until }),
             "sort": params?.sort ? params.sort : "-createdAt",
diff --git a/resources/transactions.ts b/resources/transactions.ts
@@ -35,7 +35,7 @@ export class Transactions extends BaseResource {
             ...(params?.accountId && { "filter[accountId]": params.accountId }),
             ...(params?.customerId && { "filter[customerId]": params.customerId }),
             ...(params?.query && { "filter[query]": params.query }),
-            ...(params?.tags && { "filter[tags]": params.tags }),
+            ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),
             ...(params?.since && { "filter[since]": params.since }),
             ...(params?.until && { "filter[until]": params.until }),
             ...(params?.cardId && { "filter[cardId]": params.cardId }),
diff --git a/tests/cards.spec.ts b/tests/cards.spec.ts
@@ -148,3 +148,14 @@ describe("Create Card", () => {
         expect(updateRes.data.attributes.tags).toStrictEqual(res.data.attributes.tags)
     })
 })
+
+describe("Cards List with filter", () => {
+    test("Get Cards List with filter", async () => {
+        const res = await unit.cards.list({tags: {"test": "test"}})
+        expect(res.data.length).toBeGreaterThan(0)
+        res.data.forEach(element => {
+            expect(cardTypes.includes(element.type)).toBeTruthy()
+            cardsId.push(element.id)
+        })
+    })
+})

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ export class Applications extends BaseResource {`
`17`	`17`	`"page[offset]": (params?.offset ? params?.offset : 0),`
`18`	`18`	`...(params?.query && { "filter[query]": params?.query }),`
`19`	`19`	`...(params?.email && { "filter[email]": params?.email }),`
`20`		`- ...(params?.tags && { "filter[tags]": params?.tags }),`
	`20`	`+ ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),`
`21`	`21`	`"sort": params?.sort ? params.sort : "-createdAt"`
`22`	`22`	`}`
`23`	`23`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export class ApplicationForms extends BaseResource {`
`20`	`20`	`const parameters = {`
`21`	`21`	`"page[limit]": (params?.limit ? params?.limit : 100),`
`22`	`22`	`"page[offset]": (params?.offset ? params?.offset : 0),`
`23`		`- ...(params?.tags && { "filter[tags]": params?.tags }),`
	`23`	`+ ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),`
`24`	`24`	`...(params?.sort && { "sort": params.sort })`
`25`	`25`	`}`
`26`	`26`	`return this.httpGet<UnitResponse<ApplicationForm[]>>("", { params: parameters })`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ export class Cards extends BaseResource {`
`70`	`70`	`...(params?.accountId && { "filter[accountId]": params.accountId }),`
`71`	`71`	`...(params?.customerId && { "filter[customerId]": params.customerId }),`
`72`	`72`	`...(params?.include && { "include": params.include }),`
`73`		`- ...(params?.tags && { "filter[tags]": params?.tags }),`
	`73`	`+ ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),`
`74`	`74`	`"sort": params?.sort ? params.sort : "-createdAt"`
`75`	`75`	`}`
`76`	`76`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ export class Chargebacks extends BaseResource {`
`32`	`32`	`...(params?.customerId && {"filter[customerId]": params.customerId}),`
`33`	`33`	`...(params?.since && {"filter[since]": params.since}),`
`34`	`34`	`...(params?.until && {"filter[until]": params.until}),`
`35`		`- ...(params?.tags && {"filter[tags]": params.tags}),`
	`35`	`+ ...(params?.tags && {"filter[tags]": JSON.stringify(params.tags)}),`
`36`	`36`	`...(params?.include && {"include": params.include}),`
`37`	`37`	`...(params?.sort && {"sort": params.sort})`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export class CheckDeposits extends BaseResource {`
`16`	`16`	`"page[offset]": (params?.offset ? params.offset : 0),`
`17`	`17`	`...(params?.accountId && { "filter[accountId]": params.accountId }),`
`18`	`18`	`...(params?.customerId && { "filter[customerId]": params.customerId }),`
`19`		`- ...(params?.tags && { "filter[tags]": params.tags }),`
	`19`	`+ ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),`
`20`	`20`	`"sort": params?.sort ? params.sort : "-createdAt",`
`21`	`21`	`"include": params?.include ? params.include : "include"`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export class Customers extends BaseResource {`
`23`	`23`	`"page[offset]": (params?.offset ? params.offset : 0),`
`24`	`24`	`...(params?.query && { "filter[query]": params.query }),`
`25`	`25`	`...(params?.email && { "filter[email]": params.email }),`
`26`		`- ...(params?.tags && { "filter[tags]": params.tags }),`
	`26`	`+ ...(params?.tags && { "filter[tags]": JSON.stringify(params.tags) }),`
`27`	`27`	`"sort": params?.sort ? params.sort : "-createdAt"`
`28`	`28`	`}`
`29`	`29`