TODOs

Author: keisar

raft/src/main/scala/zio/raft/Raft.scala

@@ -917,6 +917,8 @@ class Raft[S, A <: Command](
         s"memberId=${this.memberId} validateLeadership: ${peersRequiringHeartbeat.length}/${peers.length} peers requiring heartbeat"
       )
 
+      // TODO (eran): TBD with Doron: as per Raft paper, we might want to always send heartbeat and not rely on the heartbeat due time
+      
       // If majority of peers don't require heartbeat, leadership is likely valid
       // peersRequiringHeartbeat.length < numberOfServers / 2 means:
       // - peers not requiring heartbeat + self > numberOfServers / 2 (majority)

raft/src/main/scala/zio/raft/Types.scala

@@ -47,6 +47,7 @@ case class ClusterConfiguration(
 ):
   def numberOfServers = 1 + peers.length
 
+  // TODO (eran): is this correct? should it be numberOfServers / 2 + 1?
   def quorum = numberOfServers / 2
 
 trait Command: