-
-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
bugSomething isn't workingSomething isn't working
Description
🐛 The bug
Currently, resolveFont
for each provider is cached using a key that is partially made of the family options hash. That's great but if you use some providers options then change them, cache is not invalidated.
🛠️ To reproduce
https://stackblitz.com/edit/github-pkgkk2lt?file=cache.js
🌈 Expected behaviour
Take the provider options into account, when applicable (ie. only for google providers atm).
ℹ️ Additional context
I'd be happy to submit a PR. Note there's overlap with #183 since the proposed design would solve this issue entirely
danielroe and sushichan044
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working