coding style more fixes

Author: MichaelXt

Assets/UI/InfoWidgets/FinanceAndResourceOverlay.gd

@@ -22,7 +22,7 @@ func on_context_changed(context: BaseContext) -> void:
     building = building_context.building_to_build
   else: # if the context is not the building context disconnect the update signal
     var remembered_building_context := self.current_context as BuildingContext
-    if remembered_building_context != null and remembered_building_context.building_changed.is_connected(self.on_building_changed) == true:
+    if remembered_building_context != null and remembered_building_context.building_changed.is_connected(self.on_building_changed):
       remembered_building_context.building_changed.disconnect(self.on_building_changed)
 
   if building != &"":

Assets/World/Components/Collectors/Collector.gd

@@ -402,7 +402,8 @@ func get_jobs_for_lumberjack_collector() -> Array[Job]:
       var cell_data: TileData = self.built_tilemap.get_cell_tile_data(cell)
       if cell_data == null:
         continue
-      if cell_data.get_custom_data(self.built_tilemap.is_tree) == true:
+      var is_tree: bool = cell_data.get_custom_data(self.built_tilemap.is_tree)
+      if is_tree:
         if cell in self.built_tilemap.trees_getting_choped:
           continue
         var path_to_start: Array[Vector2i] = self.get_cell_path(collector_map_position, cell) # to cell

Assets/World/Components/CommandableComponent/CommandableComponent.gd

@@ -26,7 +26,7 @@ func set_components(new_components: Array[BaseComponent]) -> void:
 
 func handle_context_input(event: InputEvent):
   if event is InputEventMouseButton:
-    if event.pressed == true:
+    if event.pressed:
       if event.button_index == MOUSE_BUTTON_RIGHT:
         self.add_checkpoint() # fire and forget
 

Assets/World/Components/ProductionLine/ProductionLineComponent.gd

@@ -151,16 +151,16 @@ func update_resource_storage_tooltips(has_enough_resources: bool, has_output_spa
       if self.inventory_full_tooltip.visible == false:
         self.inventory_full_tooltip.visible = true
         self.inventory_full_tooltip.play("inventory_full")
-    elif self.inventory_full_tooltip.visible == true:
+    elif self.inventory_full_tooltip.visible:
       self.inventory_full_tooltip.visible = false
       self.inventory_full_tooltip.stop()
 
   if self.show_resource_deficit_tooltip:
-    if has_enough_resources == false and has_output_space == true: # show resource deficit
+    if has_enough_resources == false and has_output_space: # show resource deficit
       if self.resource_deficit_tooltip.visible == false:
         self.resource_deficit_tooltip.visible = true
         self.resource_deficit_tooltip.play("resource_deficit")
-    elif self.resource_deficit_tooltip.visible == true:
+    elif self.resource_deficit_tooltip.visible:
       self.resource_deficit_tooltip.visible = false
       self.resource_deficit_tooltip.stop()
 

Assets/World/Context/BuildingContext.gd

@@ -87,7 +87,7 @@ func _unhandled_input(event: InputEvent) -> void:
       self.update_building_highlight()
 
     var mouseButtonEvent := event as InputEventMouseButton
-    if mouseButtonEvent != null and mouseButtonEvent.pressed == true:
+    if mouseButtonEvent != null and mouseButtonEvent.pressed:
       if mouseButtonEvent.button_index == MOUSE_BUTTON_LEFT:
         self.build(self.building_to_build, self.building_instance)
         return

Assets/World/Context/BuildingRoadContext.gd

@@ -39,9 +39,10 @@ func _unhandled_input(event):
     self.game_context_manager.current_context = self
 
   if self.is_active:
-    if event is InputEventMouseButton:
-      if event.pressed == true:
-        if event.button_index == MOUSE_BUTTON_LEFT:
+    var mouseButtonEvent := event as InputEventMouseButton
+    if mouseButtonEvent != null:
+      if mouseButtonEvent.pressed:
+        if mouseButtonEvent.button_index == MOUSE_BUTTON_LEFT:
           respond_to_left_click()
 
     if event.is_action_pressed("cancel"):

Assets/World/Context/DemolitionContext.gd

@@ -25,8 +25,9 @@ func _unhandled_input(event: InputEvent) -> void:
 
   if self.is_active:
     var mouse_cell := self.built_tilemap.local_to_map(self.built_tilemap.get_global_mouse_position())
-    if event is InputEventMouseButton:
-      if event.button_index == MOUSE_BUTTON_LEFT and event.pressed == true:
+    var mouseButtonEvent := event as InputEventMouseButton
+    if mouseButtonEvent != null:
+      if mouseButtonEvent.button_index == MOUSE_BUTTON_LEFT and mouseButtonEvent.pressed:
         self.demolish(mouse_cell)
 
     if event.is_action_pressed("cancel"):

Assets/World/Context/SelectionBox.gd

@@ -7,9 +7,10 @@ var sel_pos_start := Vector2(0,0) # first click position
 @export var line_color: Color = Color(1, 1, 1, 0.5)
 
 func _unhandled_input(event):
-  if event is InputEventMouseButton:
-    if event.button_index == MOUSE_BUTTON_LEFT:
-      if event.pressed == true:
+  var mouseButtonEvent := event as InputEventMouseButton
+  if mouseButtonEvent != null:
+    if mouseButtonEvent.button_index == MOUSE_BUTTON_LEFT:
+      if mouseButtonEvent.pressed:
         sel_pos_start = get_viewport().get_mouse_position()
 
 func _process(_delta: float) -> void:

Assets/World/Context/SelectionContext.gd

@@ -17,9 +17,10 @@ func context_entered() -> void:
 
 func _unhandled_input(event):
   if self.is_active or object_selected_context.is_active:
-    if event is InputEventMouseButton:
-      if event.button_index == MOUSE_BUTTON_LEFT:
-        if event.pressed == true:
+    var mouseButtonEvent := event as InputEventMouseButton
+    if mouseButtonEvent != null:
+      if mouseButtonEvent.button_index == MOUSE_BUTTON_LEFT:
+        if mouseButtonEvent.pressed:
           # print(built_tilemap.get_global_mouse_position())
           selection_rect.position = built_tilemap.get_global_mouse_position()
           selection_box.visible = true

DevTools/AnimationTemplate.j2

@@ -40,4 +40,4 @@ animations = [{
 },
   {%- endfor %}
 {% endfor %}
-]
+]