Commit 4d37d41
refactor(fit-app): drop macOS Dock P/Invoke; address review comments
Samples must not use unmanaged code. Remove the AppKit P/Invoke Dock-icon path
(MacOSDockIcon.cs, App.Desktop.cs, DockIcon.png + its wiring in App.xaml.cs and
the csproj). The branded icon still ships via Uno.Resizetizer — the app icon on
every platform, and the packaged macOS .app shows it in the Dock; the generic
tile on an unbundled `dotnet run` is an accepted dev-only cosmetic limitation.
Also dispose the previous PathGeometry before replacing it in
WeeklyRing.UpdateArc (flagged by review).
Addresses the github-code-quality review on #930.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 2a643a4 commit 4d37d41
6 files changed
Lines changed: 5 additions & 141 deletions
File tree
- studio/fit-app/FitBeginnerApp
- Platforms/Desktop
- Presentation
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | 90 | | |
95 | 91 | | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | 92 | | |
100 | 93 | | |
101 | 94 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | 64 | | |
Lines changed: 0 additions & 24 deletions
This file was deleted.
Binary file not shown.
Lines changed: 0 additions & 99 deletions
This file was deleted.
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
| 138 | + | |
137 | 139 | | |
138 | 140 | | |
139 | 141 | | |
| |||
161 | 163 | | |
162 | 164 | | |
163 | 165 | | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
164 | 169 | | |
165 | 170 | | |
166 | 171 | | |
| |||
0 commit comments