Skip to content

Commit f4f7ba8

Browse files
kazo0claude
andcommitted
ci: Use the wasm runner's --filter instead of a duplicate query param
The filter wiring from 9f0a6f9 took effect ("Test filter: Given_MsalAuthentication" in the log) and WebAssembly still hung identically - 408 requests, no results, browser alive at 1800s - so the filter was not the cause here. The runner builds its own test URL and already sets UNO_RUNTIME_TESTS_RUN_TESTS on it. Passing that same key via --query-param produced a URL carrying it twice: ...&UNO_RUNTIME_TESTS_RUN_TESTS=true&...&UNO_RUNTIME_TESTS_RUN_TESTS=%7B... so the app never started a run. The runner exposes a first-class `--filter` option (confirmed from its --help, and visible in the log as "[WasmRunner] Filter: (none)"); switched to that and dropped the query param. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014FLT6rr6WyK7R4wAtnQzEd
1 parent 9f0a6f9 commit f4f7ba8

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

build/test-scripts/wasm-runtime-tests.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,15 @@ popd >/dev/null
6363

6464
echo "Test filter: ${TEST_FILTER}"
6565

66+
# --filter, NOT --query-param UNO_RUNTIME_TESTS_RUN_TESTS: the runner sets that parameter itself
67+
# (as `=true`) when building the test URL, so passing it again produced a URL carrying
68+
# UNO_RUNTIME_TESTS_RUN_TESTS twice and the app never started the run - it just sat there until the
69+
# 1800s timeout with the browser still open. The runner has a first-class filter option; use it.
6670
uno-runtimetests-wasm \
6771
--app-path "${RuntimeTestsArtifactPath}" \
6872
--output "${results_path}" \
6973
--timeout 1800 \
70-
--query-param "UNO_RUNTIME_TESTS_RUN_TESTS={\"Filter\":{\"Value\":\"${TEST_FILTER}\"}}" \
74+
--filter "${TEST_FILTER}" \
7175
--browser-log-level verbose \
7276
2>&1 | tee -a "${runner_log_path}"
7377

0 commit comments

Comments
 (0)