Merge pull request #22303 from unoplatform/dev/xygu/20251210/dc-lifecycle

fix: inherited dc lifecycle

Author: Xiaoy312

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_UIElement.DataContext.cs

@@ -0,0 +1,68 @@
+using System.Threading.Tasks;
+using Microsoft.UI;
+using Microsoft.UI.Xaml;
+using Microsoft.UI.Xaml.Controls;
+using Microsoft.UI.Xaml.Media;
+using Uno.UI.Extensions;
+using Uno.UI.RuntimeTests.Helpers;
+
+namespace Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml;
+
+partial class Given_UIElement
+{
+	[TestMethod]
+	[RunsOnUIThread]
+	[PlatformCondition(ConditionMode.Include, RuntimeTestPlatforms.Skia)]
+	public async Task When_Subtree_SeveredFromDataContextSource()
+	{
+		const int DC = 312;
+
+		var nested2 = new Border() { Name = "nested2" };
+		var nested1 = new Border() { Name = "nested1", Child = nested2 };
+		var host = new Border() { Name = "host", Child = nested1 };
+		await UITestHelper.Load(host, x => x.IsLoaded);
+
+		host.DataContext = DC;
+		Assert.AreEqual(DC, nested1.DataContext, "1. initially, DC (nested1) should be inherited");
+		Assert.AreEqual(DC, nested2.DataContext, "1. initially, DC (nested2) should be inherited");
+
+		host.Child = null;
+		Assert.IsNull(nested1.DataContext, "2. when detached, inherited DC(nested1) should be cleared");
+		Assert.IsNull(nested2.DataContext, "2. when detached, inherited DC(nested2) should be cleared");
+
+		host.Child = nested1;
+		Assert.AreEqual(DC, nested1.DataContext, "3. when reattached, DC (nested1) should be inherited again");
+		Assert.AreEqual(DC, nested2.DataContext, "3. when reattached, DC (nested2) should be inherited again");
+	}
+
+	[TestMethod]
+	[RunsOnUIThread]
+	[PlatformCondition(ConditionMode.Include, RuntimeTestPlatforms.Skia)]
+	public async Task When_SeveredSubtree_ContainsDataContextSource()
+	{
+		const int DC = 312;
+
+		//   v detachment point
+		// H > N1 > N2 > N3 > N4
+		//          ^ DC owner, and propagation source
+		//               ^  + ^ inherited DC
+		var nested4 = new Border() { Name = "nested4", };
+		var nested3 = new Border() { Name = "nested3", Child = nested4 };
+		var nested2 = new Border() { Name = "nested2", Child = nested3 };
+		var nested1 = new Border() { Name = "nested1", Child = nested2 };
+		var host = new Border() { Name = "host", Child = nested1 };
+		await UITestHelper.Load(host, x => x.IsLoaded);
+
+		nested2.DataContext = DC;
+		Assert.AreEqual(DC, nested3.DataContext, "1. initially, DC (nested3) should be inherited");
+		Assert.AreEqual(DC, nested4.DataContext, "1. initially, DC (nested4) should be inherited");
+
+		host.Child = null;
+		Assert.AreEqual(DC, nested3.DataContext, "2. when detached, DC (nested3) should still be inherited&unaffected");
+		Assert.AreEqual(DC, nested4.DataContext, "2. when detached, DC (nested4) should still be inherited&unaffected");
+
+		host.Child = nested1;
+		Assert.AreEqual(DC, nested3.DataContext, "3. when reattached, DC (nested3) should still be inherited&unaffected");
+		Assert.AreEqual(DC, nested4.DataContext, "3. when reattached, DC (nested4) should still be inherited&unaffected");
+	}
+}

src/Uno.UI/UI/Xaml/DependencyObjectStore.cs

@@ -644,7 +644,7 @@ private void TryApplyDataContextOnPrecedenceChange(
 		}
 
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]
-		private void ClearInheritedDataContext()
+		internal void ClearInheritedDataContext()
 		{
 			ClearValue(_dataContextProperty, DependencyPropertyValuePrecedences.Inheritance);
 		}

src/Uno.UI/UI/Xaml/UIElement.crossruntime.cs

@@ -102,6 +102,7 @@ private void OnChildAdded(UIElement child)
 		private void OnChildRemoved(UIElement child)
 		{
 			child.Shutdown();
+			(child as IDependencyObjectStoreProvider)?.Store.ClearInheritedDataContext();
 
 #if UNO_HAS_ENHANCED_LIFECYCLE
 			var leaveParams = new LeaveParams(IsActiveInVisualTree);