Merge pull request #22126 from ramezgerges/wasm_segfault

fix(wasm): out of memory access when calling ubrk_open

Author: ramezgerges

src/Directory.Build.targets

@@ -76,7 +76,7 @@
 		<MicrosoftTestingPlatformVersion>1.9.0</MicrosoftTestingPlatformVersion>
 		<SkiaSharpVersion>3.119.0</SkiaSharpVersion>
 		<HarfbuzzSharpVersion>8.3.1.1</HarfbuzzSharpVersion>
-		<UnoICUVersion>77.1.0-dev.45</UnoICUVersion>
+		<UnoICUVersion>77.1.0-dev.46</UnoICUVersion>
 	</PropertyGroup>
 
 	<ItemGroup>

src/Uno.UI/UI/Xaml/Documents/UnicodeText.ICU.skia.cs

@@ -96,16 +96,15 @@ static unsafe ICU()
 					.Where(t => t.Item2 != null)
 					.Select(t => t.a.GetManifestResourceStream(t.Item2!))
 					.First()!;
-				var data = new byte[stream.Length];
-				stream.ReadExactly(data, 0, data.Length);
-				fixed (byte* dataPtr = data)
+				// udata_setCommonData does not copy the buffer, so it needs to be pinned.
+				// For alignment, the ICU docs require 16-byte alignment. https://unicode-org.github.io/icu/userguide/icu_data/#alignment
+				var data = NativeMemory.AlignedAlloc((UIntPtr)stream.Length, 16);
+				stream.ReadExactly(new Span<byte>(data, (int)stream.Length));
+				var errorPtr = BrowserICUSymbols.uno_udata_setCommonData((IntPtr)data);
+				var errorString = Marshal.PtrToStringUTF8(errorPtr);
+				if (errorString is not null)
 				{
-					var errorPtr = BrowserICUSymbols.uno_udata_setCommonData((IntPtr)dataPtr);
-					var errorString = Marshal.PtrToStringUTF8(errorPtr);
-					if (errorString is not null)
-					{
-						throw new InvalidOperationException($"uno_udata_setCommonData failed: {errorString}");
-					}
+					throw new InvalidOperationException($"uno_udata_setCommonData failed: {errorString}");
 				}
 
 				// ICU is included in the dotnet runtime itself