Skip to content

Commit 9dc1252

Browse files
committed
chore: Do not dump HR logs unless explicitly requested!
1 parent e096766 commit 9dc1252

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/Uno.UI.RemoteControl.Server.Processors/HotReload/MetadataUpdates/CompilationWorkspaceProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ internal static class CompilationWorkspaceProvider
2828
Dictionary<string, string> properties,
2929
CancellationToken ct)
3030
{
31-
if (properties.TryGetValue("UnoHotReloadDiagnosticsLogPath", out var logPath))
31+
if (properties.TryGetValue("UnoHotReloadDiagnosticsLogPath", out var logPath) && logPath is { Length: > 0 })
3232
{
3333
// Sets Roslyn's environment variable for troubleshooting HR, see:
3434
// https://github.com/dotnet/roslyn/blob/fc6e0c25277ff440ca7ded842ac60278ee6c9695/src/Features/Core/Portable/EditAndContinue/EditAndContinueService.cs#L72

src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ private async Task<HotReloadWorkspace> CreateCompilation(ConfigureServer configu
203203
string? Trim(string? outDir)
204204
{
205205
var result = outDir;
206-
while(!string.IsNullOrWhiteSpace(result))
206+
while (!string.IsNullOrWhiteSpace(result))
207207
{
208208
var updated = result
209209
.TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar)

0 commit comments

Comments
 (0)