fix: Handle value types (structs) in BindableTypeProviders generator

Copilot · jeromelaban · Copilot · commit d085b670134b · 2025-12-01T16:35:53.000Z
Co-authored-by: jeromelaban &lt;5839577+jeromelaban@users.noreply.github.com&gt;
diff --git a/src/SourceGenerators/Uno.UI.SourceGenerators/BindableTypeProviders/BindableTypeProvidersGenerationTask.cs b/src/SourceGenerators/Uno.UI.SourceGenerators/BindableTypeProviders/BindableTypeProvidersGenerationTask.cs
@@ -364,10 +364,15 @@ where field.IsStatic
 								continue;
 							}
 
+							// For value types (structs), we cannot generate setters because modifying an unboxed value type
+							// creates a temporary copy that is immediately discarded. Only generate getters for structs.
+							var isValueType = ownerType.TypeKind == TypeKind.Struct;
+
 							if (
 								property.SetMethod != null
 								&& !property.SetMethod.IsInitOnly
 								&& property.SetMethod.IsLocallyPublic(_currentModule!)
+								&& !isValueType
 								)
 							{
 								writer.AppendLineIndented($@"bindableType.AddProperty(""{propertyName}"", typeof({propertyTypeName}), Get{propertyName}, Set{propertyName});");

Original file line number	Diff line number	Diff line change
`@@ -364,10 +364,15 @@ where field.IsStatic`
`364`	`364`	`continue;`
`365`	`365`	`}`
`366`	`366`
	`367`	`+ // For value types (structs), we cannot generate setters because modifying an unboxed value type`
	`368`	`+ // creates a temporary copy that is immediately discarded. Only generate getters for structs.`
	`369`	`+ var isValueType = ownerType.TypeKind == TypeKind.Struct;`
	`370`	`+`
`367`	`371`	`if (`
`368`	`372`	`property.SetMethod != null`
`369`	`373`	`&& !property.SetMethod.IsInitOnly`
`370`	`374`	`&& property.SetMethod.IsLocallyPublic(_currentModule!)`
	`375`	`+ && !isValueType`
`371`	`376`	`)`
`372`	`377`	`{`
`373`	`378`	`writer.AppendLineIndented($@"bindableType.AddProperty(""{propertyName}"", typeof({propertyTypeName}), Get{propertyName}, Set{propertyName});");`