You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not really worth a long thread, but I was just wondering why some components use arbitrary or custom Tailwind values instead of existing ones. Doesn't that result in unnecessary classes?
For example in the NavigationMenu top values are currently custom.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Not really worth a long thread, but I was just wondering why some components use arbitrary or custom Tailwind values instead of existing ones. Doesn't that result in unnecessary classes?
For example in the NavigationMenu top values are currently custom.
shadcn-vue/apps/www/src/registry/default/ui/navigation-menu/NavigationMenuIndicator.vue
Lines 17 to 24 in e39e2c7
Where
top-[60%]
could also be the existingtop-3/5
shadcn-vue/apps/v4/registry/new-york-v4/ui/navigation-menu/NavigationMenuTrigger.vue
Lines 23 to 35 in e39e2c7
Where
top-[1px]
can also be the existingtop-px
If it is an improvement I'm happy to start a pull request, but there might be a very good reason to do it like this.
Beta Was this translation helpful? Give feedback.
All reactions