Skip to content

Commit 0d48e81

Browse files
committed
Move tests back into original project
- The sample project was more effort to maintain than including example tests in the project
1 parent a72f3ee commit 0d48e81

File tree

4 files changed

+16
-48
lines changed

4 files changed

+16
-48
lines changed

pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,13 @@
168168
<artifactId>junit</artifactId>
169169
<version>${junit.version}</version>
170170
</dependency>
171+
172+
<dependency>
173+
<groupId>com.codeborne</groupId>
174+
<artifactId>phantomjsdriver</artifactId>
175+
<version>1.2.1</version>
176+
<scope>test</scope>
177+
</dependency>
171178
</dependencies>
172179

173180
<distributionManagement>

sample-project/pom.xml

Lines changed: 0 additions & 46 deletions
This file was deleted.

sample-project/src/test/java/co/unruly/flick/ExampleTest.java renamed to src/test/java/co/unruly/flick/ExampleTest.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package co.unruly.flick;
22

3-
import co.unruly.flick.browser.Browser;
43
import co.unruly.flick.browser.Page;
54
import co.unruly.flick.dsl.Action;
65
import co.unruly.flick.dsl.Actor;
@@ -13,13 +12,14 @@ public class ExampleTest implements FlickDSL {
1312

1413
private static class User implements Actor {}
1514

16-
private final Browser browser = new PhantomJSBrowser();
15+
private final PhantomJSBrowser browser = new PhantomJSBrowser();
1716

1817
@Test
1918
public void shouldLoadPage() {
2019
Actor actor = new User();
2120

2221
Page page = given(actor.using(browser, "http://example.com"))
22+
.wasAbleTo(logHelloUsingJS())
2323
.hasHappened();
2424

2525
then(actor.using(browser, page))
@@ -47,6 +47,10 @@ private Action getMoreInfo() {
4747
return (browser) -> browser.findElement(By.xpath("/html/body/div/p[2]/a")).click();
4848
}
4949

50+
private Action<PhantomJSBrowser> logHelloUsingJS() {
51+
return PhantomJSBrowser::hello;
52+
}
53+
5054
private Assertion beOnPage(String expectedUrl) {
5155
return (browser) -> browser.waitUntilEquals(
5256
() -> browser.getDriver().getCurrentUrl(),

sample-project/src/test/java/co/unruly/flick/PhantomJSBrowser.java renamed to src/test/java/co/unruly/flick/PhantomJSBrowser.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,7 @@ public void shutdown() {
4444
this.driver.quit();
4545
}
4646

47+
public void hello() {
48+
((PhantomJSDriver) driver).executePhantomJS("console.log('Hello!');");
49+
}
4750
}

0 commit comments

Comments
 (0)