Skip to content

Labels with spaces in them are nonfunctional #5239

@CaptainZidgel

Description

@CaptainZidgel

To recreate:
Pick a project where the label has spaces in it. For example, this project "Cutter" https://up-for-grabs.net/#/filters?names=225 has label "good first issue". Click "Good first issue" to be taken to the github issues page. It takes you to https://github.com/rizinorg/cutter/labels/good%20first%20issue instead of https://github.com/rizinorg/cutter/labels/%22good%20first%20issue%22 (/"good first issue")
The critical difference: The first searches for issues matching is:issue state:open label:good first issue, where first issue are keywords matched in text and the label searched for is just "good" (which for most repos is invalid). The second URL will correctly search issues for label:"good first issue".

I was going to try and dig into the code and submit a PR, but it looks like all URLs are configuration based. So it will be up to the maintainer how to address this. Run a script to update all the configuration files? Just add a function to change the variable values on the site itself to wrap labels in quotes?

Image

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions