Skip to content

Commit 8fa28dd

Browse files
authored
Merge pull request #153 from upb-lea/variable_naming
update variable names for more readable
2 parents b92d64e + 60f3ec1 commit 8fa28dd

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

femmt/optimization/io.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,11 +171,12 @@ def objective(trial: optuna.Trial, config: InductorOptimizationDTO, target_and_f
171171

172172
else:
173173
# using arbitrary core sizes
174-
core_inner_diameter = trial.suggest_float("core_inner_diameter", config.core_inner_diameter_list[0], config.core_inner_diameter_list[1])
175-
window_w = trial.suggest_float("window_w", config.window_w_list[0], config.window_w_list[1])
176-
window_h = trial.suggest_float("window_h", config.window_h_list[0], config.window_h_list[1])
174+
core_inner_diameter = trial.suggest_float("core_inner_diameter",
175+
config.core_inner_diameter_min_max_list[0], config.core_inner_diameter_min_max_list[1])
176+
window_w = trial.suggest_float("window_w", config.window_w_min_max_list[0], config.window_w_min_max_list[1])
177+
window_h = trial.suggest_float("window_h", config.window_h_min_max_list[0], config.window_h_min_max_list[1])
177178

178-
litz_wire_name = trial.suggest_categorical("litz_wire_name", config.litz_wire_list)
179+
litz_wire_name = trial.suggest_categorical("litz_wire_name", config.litz_wire_name_list)
179180
litz_wire = ff.litz_database()[litz_wire_name]
180181
litz_wire_diameter = 2 * litz_wire["conductor_radii"]
181182

femmt/optimization/io_dtos.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ class InductorOptimizationDTO:
5050
# optimization parameters
5151
material_name_list: list[str]
5252
core_name_list: list[str] | None
53-
core_inner_diameter_list: list[float] | None
54-
window_w_list: list[float] | None
55-
window_h_list: list[float] | None
56-
litz_wire_list: list[str]
53+
core_inner_diameter_min_max_list: list[float] | None
54+
window_w_min_max_list: list[float] | None
55+
window_h_min_max_list: list[float] | None
56+
litz_wire_name_list: list[str]
5757

5858
# FEM simulation
5959
material_data_sources: InductorMaterialDataSources

0 commit comments

Comments
 (0)