Skip to content

Commit bd33041

Browse files
committed
fix: controller doesn't need mode helm value
1 parent 3d20137 commit bd33041

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

deploy/helm/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## [1.11.0] - 2026-06-30
44

55
### Added
6-
- `node.zone` Helm value with fallback to `controller.zone`. Required for node DaemonSet to pass `--zone` to `--mode=node`
6+
- `node.zone` Helm value for the node DaemonSet. **Required** with `--mode=node` to pass `--zone` to the CSI plugin
77

88
### Changed
99
- Node DaemonSet runs `--mode=node` instead of `--mode=monolith`. UpCloud API credentials are no longer deployed to every cluster node, reducing credential blast radius

deploy/helm/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,4 @@ annotations:
2626
url: https://github.com/upcloud-tools/upcloud-csi/issues
2727
artifacthub.io/changes: |
2828
- "Node DaemonSet switches to --mode=node — credentials no longer deployed to every node"
29-
- "Add node.zone value with fallback to controller.zone — required for --mode=node to start correctly"
29+
- "Add node.zone value for the node DaemonSet — required with --mode=node"

deploy/helm/templates/node-daemonset.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,8 @@ spec:
119119
- "--endpoint=$(CSI_ENDPOINT)"
120120
- "--nodehost=$(NODE_ID)"
121121
- "--mode=node"
122-
{{- $zone := .Values.node.zone | default .Values.controller.zone }}
123-
{{- if $zone }}
124-
- "--zone={{ $zone }}"
122+
{{- with .Values.node.zone }}
123+
- "--zone={{ . }}"
125124
{{- end }}
126125
- "--address=tcp://0.0.0.0:13071"
127126
{{- if .Values.metrics.enabled }}

deploy/helm/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ controller: # @schema additionalProperties: false
126126

127127
# Node DaemonSet settings.
128128
node: # @schema additionalProperties: false
129-
# -- UpCloud zone (e.g. de-fra1). Required for --mode=node; falls back to controller.zone if empty.
129+
# -- UpCloud zone (e.g. de-fra1). Required for --mode=node.
130130
zone: "" # @schema type:string
131131

132132
# -- Log verbosity (inherits global logLevel when null).

0 commit comments

Comments
 (0)