Skip to content

Commit 7a2c505

Browse files
authored
Merge pull request #150 from bburns632/release/v0.3.0
Documentation for Release/v0.3.0
2 parents b16f43e + 8fdb385 commit 7a2c505

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+2185
-8259
lines changed

.Rbuildignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ vignettes/*\.pdf
5050
^lib$
5151
^coverage.html$
5252

53+
# Readme files
54+
^readme_figures/.*
55+
^readme_figures
56+
5357
# Stuff
5458
.Rbuildignore
5559
.*\.gitkeep
60+

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: pkgnet
22
Type: Package
33
Title: Get Network Representation of an R Package
4-
Version: 0.2.1.9000
4+
Version: 0.3.0
55
Authors@R: c(
66
person("Brian", "Burns", email = "brian.burns@uptake.com", role = c("aut", "cre")),
77
person("James", "Lamb", email = "james.lamb@uptake.com", role = c("aut")),

NEWS.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# pkgnet 0.3.0
2+
3+
## NEW FEATURES
4+
* `InheritanceReporter`, a reporter for R6, Reference, and S4 class inheritance relationships within a package. ([#14](https://github.com/UptakeOpenSource/pkgnet/issues/14), [#129](https://github.com/UptakeOpenSource/pkgnet/pull/129))
5+
* Dropdown menu in graph visualizations for selecting which node to highlight. ([#132](https://github.com/UptakeOpenSource/pkgnet/issues/132), [#143](https://github.com/UptakeOpenSource/pkgnet/pull/143))
6+
7+
## CHANGES
8+
* Edge direction reversed to align with [UML dependency diagram](https://en.wikipedia.org/wiki/Dependency_(UML)) convention. Now, if A depends on B, then A->B. ([#131](https://github.com/UptakeOpenSource/pkgnet/issues/131), [#143](https://github.com/UptakeOpenSource/pkgnet/pull/143))
9+
* Reporters now support all layouts available in igraph. Use `grep("^layout_\\S", getNamespaceExports("igraph"), value = TRUE)` to see valid options. ([#143](https://github.com/UptakeOpenSource/pkgnet/pull/143))
10+
* `FunctionReporter` now utilizes graphopt layout by default. ([#143](https://github.com/UptakeOpenSource/pkgnet/pull/143))
11+
* `FunctionReporter` now supports non-exported functions and R6 class methods. ([#123](https://github.com/UptakeOpenSource/pkgnet/issues/123), [#128](https://github.com/UptakeOpenSource/pkgnet/pull/128))
12+
* Orphaned node clustering was removed in favor of using layout to better handle graphs with many orphaned nodes. ([#102](https://github.com/UptakeOpenSource/pkgnet/issues/102), [#143](https://github.com/UptakeOpenSource/pkgnet/pull/143))
13+
* Testing strategy with subpackages are now CRAN and TRAVIS compatible. ([#121](https://github.com/UptakeOpenSource/pkgnet/issues/121), [#139](https://github.com/UptakeOpenSource/pkgnet/pull/139), [#144](https://github.com/UptakeOpenSource/pkgnet/pull/144))
14+
* Test package `milne` created for unit testing of `InheritanceReporter` and R6 method support in `FunctionReporter`. ([#128](https://github.com/UptakeOpenSource/pkgnet/issues/128), [#129](https://github.com/UptakeOpenSource/pkgnet/pull/129))
15+
* Width of html reports now adjust to size of screen. ([#143](https://github.com/UptakeOpenSource/pkgnet/pull/143))
16+
* Default node colors are now colorblind accessible. ([#130](https://github.com/UptakeOpenSource/pkgnet/issues/130), [#141](https://github.com/UptakeOpenSource/pkgnet/pull/141))
17+
* Additional various improvements to UX for package reports. ([#143](https://github.com/UptakeOpenSource/pkgnet/pull/143))
18+
19+
## BUG FIXES
20+
* Rendering of the table in Function Network tab. ([#136](https://github.com/UptakeOpenSource/pkgnet/issues/136), [#138](https://github.com/UptakeOpenSource/pkgnet/pull/138))
21+
22+
<!--- Start of NEWS.md --->

R/testing_utils.R

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@
3131
pkgnetSourcePath <- gsub('/pkgnet.Rcheck/tests_x64/testthat$', replacement = '/pkgnet.Rcheck/00_pkg_src/pkgnet', x = pkgnetSourcePath)
3232
pkgnetSourcePath <- gsub('/pkgnet.Rcheck/tests_x64$', replacement = '/pkgnet.Rcheck/00_pkg_src/pkgnet', x = pkgnetSourcePath)
3333

34+
# For R CMD check on some Linux machines that explicitly install i386
35+
pkgnetSourcePath <- gsub('/pkgnet.Rcheck/tests_i386/testthat$', replacement = '/pkgnet.Rcheck/00_pkg_src/pkgnet', x = pkgnetSourcePath)
36+
pkgnetSourcePath <- gsub('/pkgnet.Rcheck/tests_i386$', replacement = '/pkgnet.Rcheck/00_pkg_src/pkgnet', x = pkgnetSourcePath)
37+
38+
3439
pkgnetSourcePath <- gsub('/pkgnet.Rcheck/vign_test/pkgnet$', replacement = '/pkgnet.Rcheck/00_pkg_src/pkgnet', x = pkgnetSourcePath)
3540
pkgnetSourcePath <- gsub('/pkgnet/vignettes$', replacement = '/pkgnet', x = pkgnetSourcePath)
3641
pkgnetSourcePath <- gsub('pkgnet/tests/testthat', replacement = 'pkgnet', x = pkgnetSourcePath)

_pkgdown.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ navbar:
1212
href: reference/index.html
1313
- text: "Articles"
1414
href: articles/index.html
15+
- text: "News"
16+
href: news/index.html
1517

1618
right:
1719
- icon: fa-github

cran-comments.md

Lines changed: 111 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,128 @@
11
# CRAN Submission History
22

3-
## v 0.2.1 - Submission 3 - (November 1st, 2018)
3+
## v 0.3.0
44

5-
This is a minor release to address a bug with the `report_path` parameter of `CreatePackageReport`. Prior to this fix, reports would continue to be saved to a default location rather than the file path supplied by the user.
5+
### Submission on December 19th, 2018
6+
> This is a major release with several improvements to
7+
> R package diagnostics, report layout, and testing
8+
> strategy. New features and changes are now being
9+
> tracked in NEWS.md.
10+
>
11+
> This NEWS.md file and all
12+
> source code is maintained at https://github.com/UptakeOpenSource/pkgnet.
13+
14+
### CRAN Response on December 20th, 2018 (Paraphrased)
615

7-
Other items in this release are typo corrections, some additional parameter checks, and more verbose error and info messages.
16+
> Dear maintainer,
17+
>
18+
> package pkgnet_0.3.0.tar.gz does not pass the incoming checks automatically, please see the following pre-tests: Windows (2 ERRORs) & Debian (1 ERROR)
19+
>
20+
> ...
21+
>
22+
> Please fix all problems and resubmit a fixed version via the webform.
23+
>
24+
> ...
25+
>
26+
> Best regards,
27+
> CRAN teams' auto-check service
828
9-
## v 0.2.0 - Submission 2 - (April 30th, 2018)
29+
See [#154](https://github.com/UptakeOpenSource/pkgnet/pull/154) for the issue description and fix.
30+
31+
### Resubmission on December 20th, 2018
32+
> The attached package addresses issues found earlier today in the CRAN teams' auto-check service. It has been checked (via R CMD check --as-cran) on both R-core and R-devel versions today.
33+
>
34+
> This NEWS.md file and all source code is maintained at https://github.com/UptakeOpenSource/pkgnet.
35+
36+
### CRAN response on December 21st (Paraphrased)
37+
>Dear maintainer,
38+
>
39+
>package pkgnet_0.3.0.tar.gz does not pass the incoming checks automatically, please see the following pre-tests:
40+
Windows: ...
41+
Status: 1 ERROR
42+
...
43+
Warning: invalid package 'd:/RCompile/CRANincoming/R-devel/pkgnet.Rcheck/tests_i386'
44+
...
45+
Best regards,
46+
CRAN teams' auto-check service
47+
Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-ix86+x86_64
48+
49+
### Resubmission on January 2nd, 2019
50+
>Hello,
51+
>
52+
>I hope you had a refreshing holiday break.
53+
>
54+
>Apologies for the past issues with this build. I believe we have remedied the functionality that did not pass i386 tests. However, I cannot confirm this as the last submission alsopassed R CMD check on R-devel without issue. Is there a separate docker container I can use to check i386 compatibility?
55+
>
56+
>This submission passes R CMD check tests on r-devel with two warnings regarding URLs that fail within the container but have been confirmed valid and pass on R CMD check on R-core outside the container.
57+
>
58+
>Here is the version info:
59+
```
60+
> RD CMD check --as-cran pkgnet_0.3.0.tar.gz
61+
* using log directory ‘/RPackage/pkgnet.Rcheck’
62+
* using R Under development (unstable) (2018-12-21 r75875)
63+
* using platform: x86_64-pc-linux-gnu (64-bit)
64+
...
65+
```
66+
>
67+
>The exact procedure I followed is outlined here: https://alexandereckert.com/post/testing-r-packages-with-latest-r-devel/
68+
>
69+
>All source code is maintained at https://github.com/UptakeOpenSource/pkgnet.
70+
>
71+
>Sincerely,
72+
>
73+
>Brian Burns (current pkgnet maintainer)
74+
75+
### Response on January 2nd, 2019
76+
77+
>Dear maintainer,
78+
>
79+
>thanks, package pkgnet_0.3.0.tar.gz is on its way to CRAN.
80+
>
81+
>Best regards,
82+
CRAN teams' auto-check service
83+
Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-ix86+x86_64
84+
Check: CRAN incoming feasibility, Result: Note_to_CRAN_maintainers
85+
Maintainer: 'Brian Burns <brian.burns@uptake.com>'
86+
87+
---
88+
89+
## v 0.2.1
90+
91+
### Submission on November 1st, 2018
92+
93+
>This is a minor release to address a bug with the `report_path` parameter of `CreatePackageReport`. Prior to this fix, reports would continue to be saved to a default location rather than the file path supplied by the user.
94+
95+
>Other items in this release are typo corrections, some additional parameter checks, and more verbose error and info messages.
96+
97+
---
98+
99+
## v 0.2.0
100+
101+
### Submission on April 30th, 2018
10102
* Resubmitted to CRAN without test folder or source vigette code.
11103
* This was to ensure nothing is written outside of the temp folder
12104
during vignette build or package testing.
13105
* Future versions will handle this issue more directly.
14106

15-
## v0.1.0 - Submission 1 - (April 11, 2018)
107+
----
108+
109+
## v0.1.0
110+
111+
### Submission on April 12, 2018
16112

17-
### R CMD check results
113+
#### R CMD check results
114+
* No issues
115+
116+
#### CRAN Response
117+
* accepted and available on CRAN
118+
119+
### Submission on April 11, 2018
120+
121+
#### R CMD check results
18122
* One NOTE about license file, will see what they say
19123

20-
### CRAN Response
124+
#### CRAN Response
21125
* Need to use CRAN recognized LICENSE format
22126
* Need to single-quote `pkgnet` in `DESCRIPTION` file
23127

24-
## v0.1.0 - Submission 2 - (April 12, 2018)
25128

26-
### R CMD check results
27-
* No issues
28-
29-
### CRAN Response
30-
* accepted and available on CRAN

docs/CONDUCT.html

Lines changed: 24 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)