fix: close file watchers before app exit to prevent crash on macOS

Close all chokidar file watchers (collection, workspace, apiSpec) before
the Node environment is torn down. The native FSEvents watchers run on
their own threads and their cleanup races with FreeEnvironment, causing
an abort when fse_instance_destroy tries to lock a destroyed mutex.

Watchers are closed in both mainWindow.on('close') and app.on('before-quit')
to cover the native close button path and the app.exit() path.

Author: cchirag

packages/bruno-electron/src/app/apiSpecsWatcher.js

@@ -144,11 +144,9 @@ class ApiSpecWatcher {
 
   closeAllWatchers() {
     for (const [watchPath, watcher] of Object.entries(this.watchers)) {
-      if (watcher) {
-        try {
-          watcher.close();
-        } catch (err) {}
-      }
+      try {
+        watcher?.close();
+      } catch (err) {}
     }
     this.watchers = {};
     this.watcherWorkspaces = {};

packages/bruno-electron/src/app/collection-watcher.js

@@ -961,11 +961,9 @@ class CollectionWatcher {
 
   closeAllWatchers() {
     for (const [watchPath, watcher] of Object.entries(this.watchers)) {
-      if (watcher) {
-        try {
-          watcher.close();
-        } catch (err) {}
-      }
+      try {
+        watcher?.close();
+      } catch (err) {}
     }
     this.watchers = {};
   }

packages/bruno-electron/src/app/workspace-watcher.js

@@ -227,20 +227,16 @@ class WorkspaceWatcher {
 
   closeAllWatchers() {
     for (const [watchPath, watcher] of Object.entries(this.watchers)) {
-      if (watcher) {
-        try {
-          watcher.close();
-        } catch (err) {}
-      }
+      try {
+        watcher?.close();
+      } catch (err) {}
     }
     this.watchers = {};
 
     for (const [watchPath, watcher] of Object.entries(this.environmentWatchers)) {
-      if (watcher) {
-        try {
-          watcher.close();
-        } catch (err) {}
-      }
+      try {
+        watcher?.close();
+      } catch (err) {}
     }
     this.environmentWatchers = {};
 

packages/bruno-electron/src/index.js

@@ -122,6 +122,12 @@ const focusMainWindow = () => {
   }
 };
 
+const closeAllWatchers = () => {
+  collectionWatcher.closeAllWatchers();
+  workspaceWatcher.closeAllWatchers();
+  apiSpecWatcher.closeAllWatchers();
+};
+
 // Parse protocol URL from command line arguments (if any)
 appProtocolUrl = getAppProtocolUrlFromArgv(process.argv);
 
@@ -387,9 +393,7 @@ app.on('ready', async () => {
 
   mainWindow.on('close', (e) => {
     e.preventDefault();
-    collectionWatcher.closeAllWatchers();
-    workspaceWatcher.closeAllWatchers();
-    apiSpecWatcher.closeAllWatchers();
+    closeAllWatchers();
     terminalManager.cleanup(mainWindow.webContents);
     ipcMain.emit('main:start-quit-flow');
   });
@@ -462,9 +466,7 @@ app.on('ready', async () => {
 
 // Quit the app once all windows are closed
 app.on('before-quit', () => {
-  collectionWatcher.closeAllWatchers();
-  workspaceWatcher.closeAllWatchers();
-  apiSpecWatcher.closeAllWatchers();
+  closeAllWatchers();
   // Release single instance lock to allow other instances to take over
   if (useSingleInstance && gotTheLock) {
     app.releaseSingleInstanceLock();