fix: app crash on clicking close button \n Added collection, workspace, and api spec watcher cleanup on app close method

Author: cchirag

packages/bruno-electron/src/app/apiSpecsWatcher.js

@@ -141,6 +141,18 @@ class ApiSpecWatcher {
       delete this.watcherWorkspaces[watchPath];
     }
   }
+
+  closeAllWatchers() {
+    for (const [watchPath, watcher] of Object.entries(this.watchers)) {
+      if (watcher) {
+        try {
+          watcher.close();
+        } catch (err) {}
+      }
+    }
+    this.watchers = {};
+    this.watcherWorkspaces = {};
+  }
 }
 
 module.exports = ApiSpecWatcher;

packages/bruno-electron/src/app/collection-watcher.js

@@ -958,6 +958,17 @@ class CollectionWatcher {
       .filter(([path, watcher]) => !!watcher)
       .map(([path, _watcher]) => path);
   }
+
+  closeAllWatchers() {
+    for (const [watchPath, watcher] of Object.entries(this.watchers)) {
+      if (watcher) {
+        try {
+          watcher.close();
+        } catch (err) {}
+      }
+    }
+    this.watchers = {};
+  }
 }
 
 const collectionWatcher = new CollectionWatcher();

packages/bruno-electron/src/app/workspace-watcher.js

@@ -224,6 +224,28 @@ class WorkspaceWatcher {
   hasWatcher(workspacePath) {
     return Boolean(this.watchers[workspacePath]);
   }
+
+  closeAllWatchers() {
+    for (const [watchPath, watcher] of Object.entries(this.watchers)) {
+      if (watcher) {
+        try {
+          watcher.close();
+        } catch (err) {}
+      }
+    }
+    this.watchers = {};
+
+    for (const [watchPath, watcher] of Object.entries(this.environmentWatchers)) {
+      if (watcher) {
+        try {
+          watcher.close();
+        } catch (err) {}
+      }
+    }
+    this.environmentWatchers = {};
+
+    dotEnvWatcher.closeAll();
+  }
 }
 
 module.exports = WorkspaceWatcher;

packages/bruno-electron/src/index.js

@@ -387,6 +387,9 @@ app.on('ready', async () => {
 
   mainWindow.on('close', (e) => {
     e.preventDefault();
+    collectionWatcher.closeAllWatchers();
+    workspaceWatcher.closeAllWatchers();
+    apiSpecWatcher.closeAllWatchers();
     terminalManager.cleanup(mainWindow.webContents);
     ipcMain.emit('main:start-quit-flow');
   });
@@ -459,6 +462,9 @@ app.on('ready', async () => {
 
 // Quit the app once all windows are closed
 app.on('before-quit', () => {
+  collectionWatcher.closeAllWatchers();
+  workspaceWatcher.closeAllWatchers();
+  apiSpecWatcher.closeAllWatchers();
   // Release single instance lock to allow other instances to take over
   if (useSingleInstance && gotTheLock) {
     app.releaseSingleInstanceLock();