fix: create schedule if additional volumes are used (#455)

* fix: create schedule if additional volumes are used

* test: add no backup schedule for additional volumes with backups disabled

Author: shreddedbacon

cmd/template_backups_test.go

@@ -332,6 +332,45 @@ func TestBackupTemplateGeneration(t *testing.T) {
 			templatePath: "testoutput",
 			want:         "internal/testdata/node/backup-templates/test-generic-backup-rootless-workloads-onrootmismatch",
 		},
+		{
+			name: "schedules-with-additional-volumes",
+			args: testdata.GetSeedData(
+				testdata.TestData{
+					ProjectName:     "example-project",
+					EnvironmentName: "main",
+					Branch:          "main",
+					LagoonYAML:      "internal/testdata/basic/lagoon.multiple-volumes-2.yml",
+					ProjectVariables: []lagoon.EnvironmentVariable{
+						{
+							Name:  "LAGOON_FEATURE_FLAG_IMAGECACHE_REGISTRY",
+							Value: "imagecache.example.com",
+							Scope: "global",
+						},
+					},
+				}, true),
+			templatePath: "testoutput",
+			want:         "internal/testdata/basic/backup-templates/schedules-with-additional-volumes",
+		},
+		{
+			name: "no-schedules-with-additional-volumes-with-no-backups",
+			args: testdata.GetSeedData(
+				testdata.TestData{
+					ProjectName:     "example-project",
+					EnvironmentName: "main",
+					Branch:          "main",
+					LagoonYAML:      "internal/testdata/basic/lagoon.additional-volumes-no-backup.yml",
+					ProjectVariables: []lagoon.EnvironmentVariable{
+						{
+							Name:  "LAGOON_FEATURE_FLAG_IMAGECACHE_REGISTRY",
+							Value: "imagecache.example.com",
+							Scope: "global",
+						},
+					},
+				}, true),
+			templatePath: "testoutput",
+			emptyDir:     true,
+			want:         "internal/testdata/basic/backup-templates/schedules-with-additional-volumes-no-backup",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

internal/generator/services.go

@@ -560,6 +560,12 @@ func composeToServiceValues(
 
 			}
 		}
+		// if there are any additional volumes that have backups configured, enable the backup schedule
+		for _, v := range serviceVolumes {
+			if v.Backup {
+				backupsEnabled = true
+			}
+		}
 
 		// create the service values
 		cService := &ServiceValues{

internal/testdata/basic/backup-templates/schedules-with-additional-volumes-no-backup/.gitkeep

@@ -0,0 +1,41 @@
+---
+apiVersion: backup.appuio.ch/v1alpha1
+kind: Schedule
+metadata:
+  annotations:
+    lagoon.sh/branch: main
+    lagoon.sh/version: v2.7.x
+  creationTimestamp: null
+  labels:
+    app.kubernetes.io/instance: k8up-lagoon-backup-schedule
+    app.kubernetes.io/managed-by: build-deploy-tool
+    app.kubernetes.io/name: k8up-schedule
+    lagoon.sh/buildType: branch
+    lagoon.sh/environment: main
+    lagoon.sh/environmentType: production
+    lagoon.sh/project: example-project
+    lagoon.sh/service: k8up-lagoon-backup-schedule
+    lagoon.sh/service-type: k8up-schedule
+    lagoon.sh/template: k8up-schedule-0.1.0
+  name: k8up-lagoon-backup-schedule
+spec:
+  backend:
+    repoPasswordSecretRef:
+      key: repo-pw
+      name: baas-repo-pw
+    s3:
+      bucket: baas-example-project
+  backup:
+    resources: {}
+    schedule: 48 22 * * *
+  check:
+    resources: {}
+    schedule: 48 5 * * 1
+  prune:
+    resources: {}
+    retention:
+      keepDaily: 7
+      keepWeekly: 6
+    schedule: 48 3 * * 0
+  resourceRequirementsTemplate: {}
+status: {}

internal/testdata/basic/backup-templates/schedules-with-additional-volumes/k8up-lagoon-backup-schedule.yaml

@@ -0,0 +1,24 @@
+version: '2'
+services:
+  node:
+    networks:
+      - amazeeio-network
+      - default
+    build:
+      context: internal/testdata/basic/docker
+      dockerfile: basic.dockerfile
+    labels:
+      lagoon.type: basic
+      lagoon.volumes.scratch.path: /scratch
+    volumes:
+      - scratch:/scratch
+
+networks:
+  amazeeio-network:
+    external: true
+
+volumes:
+  scratch:
+    labels:
+      lagoon.type: persistent
+      lagoon.backup: false

internal/testdata/basic/docker-compose.additional-volumes-no-backup.yml

@@ -0,0 +1,10 @@
+docker-compose-yaml: internal/testdata/basic/docker-compose.additional-volumes-no-backup.yml
+
+environment_variables:
+  git_sha: "true"
+
+environments:
+  main:
+    routes:
+      - node:
+          - example.com