UI: Confusing 'adding' and 'editing' environment and project variables

[richardgaunt]

Describe the bug

If I want to edit a project variable and then I want to edit an environment variable I become lost within a confusing workflow.

To Reproduce

Editing Environment Variables

1. I navigate to a project
2. I select a Variables
3. I click "Edit" a project variable
4. I edit or add a project variable
5. And then I want to now add or edit an environment variable
6. I cannot because I am no longer on the page I went to

I need to navigate back to project, then find the environment then go to variables

There is an invisible navigation with no way back.

The only indication of change is if I read the URL bar and the Environment variables section disappears.

Expected behavior

I should not be navigated to a project variables page, I should be still within the environment variables page.

[jackwrfuller]

Hey @richardgaunt , thank you for the report!

I tested this out myself, and I agree that it seems like inconsistent behaviour. I've had a go at tweaking the UI to use the same 'project variables' component that the project variables page uses itself.

Check it out here: https://github.com/jackwrfuller/lagoon-ui/tree/project-variables

If you think it solves your issue (and doesnt introduce any regressions), I'll submit a PR.