Incremental type-check on module using Typepal fails on second check

[toinehartman]

Describe the bug

When type-checking a type-checker written with Typepal, for example https://github.com/SWAT-engineering/bird/blob/main/bird-core/src/main/rascal/lang/bird/Checker.rsc, errors are produces on the second check (but not the first).

To Reproduce

Steps to reproduce the behavior:

test bool changeMultipleTimes() {
    loc projDir = resolveLocation(|home:///swat/projects/bird/bird-core|); // <-- location of you Bird repo
    loc checkerModule = projDir + "src" + "main" + "rascal" + "lang" + "bird" + "Checker.rsc";
    PathConfig pcfg = getProjectPathConfig(projDir);

    iprintln(pcfg);

    // Clean
    remove(pcfg.bin);

    // First check
    if (!checkModuleOK(checkerModule, pathConfig = pcfg)) { // <-- all OK
        throw "First check failed; supposed to be OK.";
    }

    // Modify
    touch(checkerModule);

    // Second check
    if (!checkModuleOK(checkerModule, pathConfig = pcfg)) { // <-- fails
        println("Second check failed");
        return false;
    }

    return true;
}

Expected behavior
Since I believe the moduel to be type-correct, both checks should succeed. If not, the first check should already fail.

Desktop (please complete the following information):

• Context: Everywhere
• Rascal Version: 3e0ccc6 (0.42.2-SNAPSHOT)

[toinehartman]

I'll try to reduce this example to make it independent of a local repository.

[toinehartman]

Way more compact and reproducable test pushed here:

rascal/src/org/rascalmpl/compiler/lang/rascalcore/check/tests/ChangeScenarioTests.rsc

Lines 755 to 795 in bde7e20

	test bool changeMultipleTimes() {
	loc projDir = |memory:///incremental-test/proj|;
	loc checkerModule = projDir + "src" + "Checker.rsc";
	PathConfig pcfg = pathConfig(
	projectRoot = projDir,
	srcs = [projDir + "src"],
	bin = projDir + "target",
	// There might be incompatibility here, since Rascal uses typepal--0.16.6-RC2 at the time of writing.
	// However, I would still expect that errors caused by that appear on the first type-check.
	libs = [TYPEPAL166, |target://rascal|]
	);
	iprintln(pcfg);
	// Clean
	remove(projDir);
	writeFile(checkerModule, "
	module Checker
	extend analysis::typepal::TypePal;
	void collect(Collector c) { ; }
	");
	// First check
	println("Initial check");
	if (!checkModuleOK(checkerModule, pathConfig = pcfg)) {
	throw "First check failed; supposed to be OK.";
	}
	int N_TRIES = 10;
	// Since this seems sporadically succeed, we run this a couple of times until it fails
	for (i <- [1..N_TRIES + 1]) {
	// Follow-up check
	println("Follow-up check #<i>");
	touch(checkerModule);
	if (!checkModuleOK(checkerModule, pathConfig = pcfg)) {
	return false;
	}
	}
	return true;
	}

[toinehartman]

Unfortunately it seems to be flaky, although that might be related to an issue that @PaulKlint and @DavyLandman have been pinning down: #2710