Skip to content

Commit 168b064

Browse files
committed
Improve Settings: rename to Troubleshooting, add log path hint, better spacing
1 parent c9b19be commit 168b064

1 file changed

Lines changed: 25 additions & 9 deletions

File tree

src/com/bpmct/trmnl_nook_simple_touch/SettingsActivity.java

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ protected void onCreate(Bundle savedInstanceState) {
4949
LinearLayout.LayoutParams statusLabelParams = new LinearLayout.LayoutParams(
5050
ViewGroup.LayoutParams.WRAP_CONTENT,
5151
ViewGroup.LayoutParams.WRAP_CONTENT);
52-
statusLabelParams.topMargin = 16;
52+
statusLabelParams.topMargin = 24;
5353
inner.addView(statusLabel, statusLabelParams);
5454

5555
statusView = new TextView(this);
@@ -69,7 +69,7 @@ protected void onCreate(Bundle savedInstanceState) {
6969
LinearLayout.LayoutParams displayLabelParams = new LinearLayout.LayoutParams(
7070
ViewGroup.LayoutParams.WRAP_CONTENT,
7171
ViewGroup.LayoutParams.WRAP_CONTENT);
72-
displayLabelParams.topMargin = 20;
72+
displayLabelParams.topMargin = 24;
7373
inner.addView(displayLabel, displayLabelParams);
7474

7575
allowSleepCheck = new CheckBox(this);
@@ -81,22 +81,34 @@ protected void onCreate(Bundle savedInstanceState) {
8181
ViewGroup.LayoutParams.WRAP_CONTENT));
8282

8383
TextView loggingLabel = new TextView(this);
84-
loggingLabel.setText("Logging");
84+
loggingLabel.setText("Troubleshooting");
8585
loggingLabel.setTextSize(14);
8686
loggingLabel.setTextColor(0xFF000000);
8787
LinearLayout.LayoutParams loggingLabelParams = new LinearLayout.LayoutParams(
8888
ViewGroup.LayoutParams.WRAP_CONTENT,
8989
ViewGroup.LayoutParams.WRAP_CONTENT);
90-
loggingLabelParams.topMargin = 20;
90+
loggingLabelParams.topMargin = 24;
9191
inner.addView(loggingLabel, loggingLabelParams);
9292

9393
fileLoggingCheck = new CheckBox(this);
94-
fileLoggingCheck.setText("Capture logs to file");
94+
fileLoggingCheck.setText("Save debug logs to file");
9595
fileLoggingCheck.setTextColor(0xFF000000);
9696
fileLoggingCheck.setChecked(ApiPrefs.isFileLoggingEnabled(this));
97-
inner.addView(fileLoggingCheck, new LinearLayout.LayoutParams(
97+
LinearLayout.LayoutParams logCheckParams = new LinearLayout.LayoutParams(
9898
ViewGroup.LayoutParams.WRAP_CONTENT,
99-
ViewGroup.LayoutParams.WRAP_CONTENT));
99+
ViewGroup.LayoutParams.WRAP_CONTENT);
100+
logCheckParams.topMargin = 8;
101+
inner.addView(fileLoggingCheck, logCheckParams);
102+
103+
TextView logHint = new TextView(this);
104+
logHint.setText("Logs saved to: /media/My Files/trmnl.log");
105+
logHint.setTextSize(11);
106+
logHint.setTextColor(0xFF666666);
107+
LinearLayout.LayoutParams logHintParams = new LinearLayout.LayoutParams(
108+
ViewGroup.LayoutParams.WRAP_CONTENT,
109+
ViewGroup.LayoutParams.WRAP_CONTENT);
110+
logHintParams.leftMargin = 4;
111+
inner.addView(logHint, logHintParams);
100112

101113
Button clearLogsButton = new Button(this);
102114
clearLogsButton.setText("Clear Logs");
@@ -106,14 +118,18 @@ public void onClick(View v) {
106118
FileLogger.clear();
107119
}
108120
});
109-
inner.addView(clearLogsButton);
121+
LinearLayout.LayoutParams clearParams = new LinearLayout.LayoutParams(
122+
ViewGroup.LayoutParams.WRAP_CONTENT,
123+
ViewGroup.LayoutParams.WRAP_CONTENT);
124+
clearParams.topMargin = 8;
125+
inner.addView(clearLogsButton, clearParams);
110126

111127
LinearLayout actions = new LinearLayout(this);
112128
actions.setOrientation(LinearLayout.HORIZONTAL);
113129
LinearLayout.LayoutParams actionsParams = new LinearLayout.LayoutParams(
114130
ViewGroup.LayoutParams.WRAP_CONTENT,
115131
ViewGroup.LayoutParams.WRAP_CONTENT);
116-
actionsParams.topMargin = 16;
132+
actionsParams.topMargin = 28;
117133
inner.addView(actions, actionsParams);
118134

119135
Button editButton = new Button(this);

0 commit comments

Comments
 (0)