Skip to content

Commit 2a60764

Browse files
authored
Merge pull request #78 from 2gn/main
Add --active flag to show only active connections
2 parents 21f329a + c0dad28 commit 2a60764

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

develop-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
pytest==6.2.5
22
wheel==0.38.1
33
mypy==0.930
4-
pylint==2.12.2
4+
pylint==4.0.4
55
twine==3.7.1
66
autoflake==1.4
77
autopep8==1.6.0

nmcli/_connection.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def up(self, name: str, wait: int = None) -> None:
3131
def down(self, name: str, wait: int = None) -> None:
3232
raise NotImplementedError
3333

34-
def show(self, name: str, show_secrets: bool = False) -> ConnectionDetails:
34+
def show(self, name: str, show_secrets: bool = False, active: bool = False) -> ConnectionDetails:
3535
raise NotImplementedError
3636

3737
def reload(self) -> None:
@@ -88,10 +88,12 @@ def down(self, name: str, wait: int = None) -> None:
8888
wait) + ['connection', 'down', name]
8989
self._syscmd.nmcli(cmd)
9090

91-
def show(self, name: str, show_secrets: bool = False) -> ConnectionDetails:
91+
def show(self, name: str, show_secrets: bool = False, active: bool = False) -> ConnectionDetails:
9292
cmd = ['connection', 'show', name]
9393
if show_secrets:
9494
cmd += ["--show-secrets"]
95+
if active:
96+
cmd += ["--active"]
9597
r = self._syscmd.nmcli(cmd)
9698
results = {}
9799
for row in r.split('\n'):

tests/test_connection.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,10 @@ def test_show():
127127
assert s.passed_parameters == [
128128
'connection', 'show', name, "--show-secrets"]
129129

130+
connection.show(name, active=True)
131+
assert s.passed_parameters == [
132+
'connection', 'show', name, "--active"]
133+
130134

131135
def test_reload():
132136
s = DummySystemCommand()

0 commit comments

Comments
 (0)