Merge pull request #82 from ushiboy/hotfix/connection-show-cmd-order

fix: Resolve status 10 error due to command order when active option is enabled

Author: ushiboy

nmcli/_connection.py

@@ -89,11 +89,12 @@ def down(self, name: str, wait: int = None) -> None:
         self._syscmd.nmcli(cmd)
 
     def show(self, name: str, show_secrets: bool = False, active: bool = False) -> ConnectionDetails:
-        cmd = ['connection', 'show', name]
-        if show_secrets:
-            cmd += ["--show-secrets"]
+        cmd = ['connection', 'show']
         if active:
             cmd += ["--active"]
+        cmd += [name]
+        if show_secrets:
+            cmd += ["--show-secrets"]
         r = self._syscmd.nmcli(cmd)
         results = {}
         for row in r.split('\n'):

tests/test_connection.py

@@ -129,7 +129,7 @@ def test_show():
 
     connection.show(name, active=True)
     assert s.passed_parameters == [
-        'connection', 'show', name, "--active"]
+        'connection', 'show', "--active", name]
 
 
 def test_reload():