Skip to content

Commit e97eb59

Browse files
committed
Apply PR review feedback: fix CSS grid and build_number parsing
1 parent 3eb62cf commit e97eb59

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

index.html

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<title>cbn-tui web</title>
77
<link
88
rel="stylesheet"
9-
href="https://cdnjs.cloudflare.com/ajax/libs/firacode/6.2.0/fira_code.min.css"
9+
href="https://cdnjs.cloudflare.com/ajax/libs/juliamono/0.061/juliamono-regular.css"
1010
/>
1111
<link data-trunk rel="rust" data-bin="cbn-web" />
1212
<style>
@@ -32,8 +32,6 @@
3232

3333
#grid {
3434
flex: 1;
35-
width: 100%;
36-
height: 100%;
3735
margin: 0;
3836
width: 100%;
3937
height: 100vh;
@@ -47,7 +45,7 @@
4745

4846
pre {
4947
margin: 0;
50-
font-family: "Fira Code", monospace;
48+
font-family: "JuliaMono", monospace;
5149
font-size: 14px;
5250
line-height: 1.4;
5351
}

src/model.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,16 @@ impl<'de> Deserialize<'de> for BuildInfo {
6767
{
6868
#[derive(Deserialize)]
6969
struct Proxy {
70-
build_number: String,
70+
build_number: Option<String>,
7171
prerelease: Option<bool>,
7272
created_at: Option<String>,
7373
release: Option<Value>,
7474
}
7575

7676
let proxy = Proxy::deserialize(deserializer)?;
7777

78-
let mut tag_name = proxy.build_number.clone();
78+
let build_number = proxy.build_number.unwrap_or_default();
79+
let mut tag_name = build_number.clone();
7980
let mut prerelease = proxy.prerelease.unwrap_or(false);
8081
let mut created_at = proxy.created_at.unwrap_or_default();
8182

@@ -93,7 +94,7 @@ impl<'de> Deserialize<'de> for BuildInfo {
9394
}
9495

9596
Ok(BuildInfo {
96-
build_number: proxy.build_number,
97+
build_number,
9798
tag_name,
9899
prerelease,
99100
created_at,

0 commit comments

Comments
 (0)