You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fingerprint in Figure 2 and subsequent Figures is different. Ideally, it would be great to have the same print throughout the norm. It would also be great to have the filename and source named so people could reproduce the images in the norm to identify if they implemented the algorithms correctly.
Figure 2d) is this the orientation that describes the ridge flow to be perpendicular to the x-axis? The caption appears to be a different description compared to norm steps 6.2.3.6. a) 6.2.4.3. a) (see issue #412), and 6.2.5.2 b).
Figure 4a) and Figure 6a) are the same, but 5a) is the mirror of 4 and 6. Ideally this would be great to have consistent.
Figure 7a) and 2d) are in the same orientation, but this is 90 degrees different from 4a), 5a) 6a). As such, this seems to be confusing as to what is meant with ridgeline orientation vs dominant ridge flow orientation.
Proposed Change
Use same print image for all figures.
Mention filename + source in a footnote
Use consistent terminology regarding ridgeline orientation and ridge flow. Descriptions in 6.2.3.6 a), 6.2.4.1. b) and 6.2.5.2. b) should refer to an image step.
Figure 5a) appears to be mirrored which could be due to the addition of PI/2 noted in issue [Standard]: 6.2.4.3. FDA Algorithm #412. If the text in 6.2.4 is updated to include the addition of PI/2, then the image can remain mirrored.
Member Body/National Committee
ISO 29794-4
Clause/Subclause
No response
Paragraph/Figure/Table
No response
Type of Comment
General
Comments
The fingerprint in Figure 2 and subsequent Figures is different. Ideally, it would be great to have the same print throughout the norm. It would also be great to have the filename and source named so people could reproduce the images in the norm to identify if they implemented the algorithms correctly.
Figure 2d) is this the orientation that describes the ridge flow to be perpendicular to the x-axis? The caption appears to be a different description compared to norm steps 6.2.3.6. a) 6.2.4.3. a) (see issue #412), and 6.2.5.2 b).
Figure 4a) and Figure 6a) are the same, but 5a) is the mirror of 4 and 6. Ideally this would be great to have consistent.
Figure 7a) and 2d) are in the same orientation, but this is 90 degrees different from 4a), 5a) 6a). As such, this seems to be confusing as to what is meant with ridgeline orientation vs dominant ridge flow orientation.
Proposed Change
Use same print image for all figures.
Mention filename + source in a footnote
Use consistent terminology regarding ridgeline orientation and ridge flow. Descriptions in 6.2.3.6 a), 6.2.4.1. b) and 6.2.5.2. b) should refer to an image step.
Figure 5a) appears to be mirrored which could be due to the addition of PI/2 noted in issue [Standard]: 6.2.4.3. FDA Algorithm #412. If the text in 6.2.4 is updated to include the addition of PI/2, then the image can remain mirrored.