Skip to content

RVU Step h is incorrect #421

@gfiumara

Description

@gfiumara

@gfiumara Highlighting this issue raised by Sven, which I mentioned during the meeting briefly.

Furthermore, RVU 6.2.5.2. h) seems to have a mistake of stating
P(x) = 1 if S(x-1) < T(x), but in 6.2.3.6. f) it is stated P(x) = 1 if S(x) < T(x)
I think it might be copy-paste error in the norm arising from
C(x) = 1 if P(x-1) ≠ P(x)

Both RVU and LCL call the same function to get the ridge valley structure and it is not compared to S(x-1)
The S(x) < T(x) seems to match the MATLAB Olsen code

NFIQ2::QualityMeasures::getRidgeValleyStructure(const cv::Mat &blockCropped, std::vector<uint8_t> &ridval, std::vector<double> &dt)
......

for (unsigned int i = 0; i < dt.size(); i++) {
		if (v3.at<double>(i, 0) < dt[i]) {
			ridval.push_back(1);
		} else {
			ridval.push_back(0);
		}
	}

Originally posted by @LarsKooijman in #394

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions