Skip to content

Clarify Back Matter Resource Resolution Order in Profile Resolution #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Mar 5, 2023

Committer Notes

Closes #1442.

Some order of operations for processing being described in back matter resource resolution and other key operations of the specification are described as 'top-down order' and similar phrases that are approachable but less precise than 'document order' for underlying markup and data languages we use, like XML, where 'document order' has a more precise meaning.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable? (intended for separate dev work tracked in another task, link later)
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

Some order of operations for processing being described in back matter
resource resolution and other key operations of the specification are
described as 'top-down order' and similar phrases that are approachable
but less precise than 'document order' for underlying markup and data
languages we use, like XML, where 'document order' has a more precise
meaning.
@aj-stein-nist aj-stein-nist requested a review from a team March 5, 2023 03:22
@aj-stein-nist aj-stein-nist self-assigned this Mar 5, 2023
@aj-stein-nist aj-stein-nist linked an issue Mar 5, 2023 that may be closed by this pull request
wendellpiez
wendellpiez previously approved these changes Mar 6, 2023
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we actually avoided the term "document order" as a specifically XML concept -- indeed this term does not appear in the XML Recommendation, and is defined formally (tmk) only in the context of XPath/XDM. Since it had no meaning for JSON, we avoided it in favor of spelling it out, i.e. top-down, depth first ordering.

Given this, should we not at least define the term if we are going to use it? Alternatively we could add a note saying "in XML, document order".

https://www.w3.org/TR/1999/REC-xpath-19991116/#data-model
https://www.w3.org/TR/query-datamodel/#document-order

I'm approving because I don't want to block this as an improvement if you consider it to be one.

@GaryGapinski
Copy link

…we actually avoided the term "document order…"

If "document order" is considered too formal, perhaps "the order of occurrence within the document" (deficiently) covers XML and JSON (presuming it entails depth first, which seems to be the case). The term linear also comes to mind.

@wendellpiez
Copy link
Contributor

Happy to see clearer language crafted. Also not opposed to saying 'document order' if it can be clarified appropriately or perhaps glossed to make sense in an object processing (i.e. JSON or YAML) context.

Note that because order of properties on objects in JSON is not defined, a data caster going from objects back into XML must look at the metaschema to know that parameters come before properties (props), for example (or know ahead of time).

@aj-stein-nist aj-stein-nist force-pushed the 1442-imprecise-description-of-profile-backmatter-resolution branch from 285b339 to 3b54234 Compare March 15, 2023 18:33
@aj-stein-nist aj-stein-nist marked this pull request as ready for review March 15, 2023 18:34
@aj-stein-nist
Copy link
Contributor Author

I made some light changes and also addressed #1442 (comment). @wendellpiez, can I get a quick re-review?

@aj-stein-nist
Copy link
Contributor Author

This was not completed in time for the remainder for Sprint 64 and higher priorities came up with Sprint 65. I will add the related issue to sprint 66 and reopen the PR or start over accordingly as time permits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imprecise description of profile backmatter resolution
3 participants