Skip to content

Commit e3ed898

Browse files
henrychoykeithmanville
authored andcommitted
fix: display banner when viewing deleted snapshots
1 parent 1b97562 commit e3ed898

4 files changed

Lines changed: 5 additions & 41 deletions

File tree

src/frontend/src/views/CreateEntryPoint.vue

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -595,18 +595,7 @@
595595
596596
watch(() => store.selectedSnapshot, (ep) => {
597597
if(ep) {
598-
entryPoint.value = {
599-
name: ep.name,
600-
group: ep.group.id,
601-
description: ep.description,
602-
parameters: ep.parameters,
603-
artifactParameters: ep.artifactParameters,
604-
taskGraph: ep.taskGraph,
605-
artifactGraph: ep.artifactGraph,
606-
queues: ep.queues,
607-
plugins: ep.plugins,
608-
artifactPlugins: ep.artifactPlugins
609-
}
598+
entryPoint.value = ep
610599
copyAtEditStart.value = entryPoint.value
611600
} else {
612601
getEntrypoint()

src/frontend/src/views/CreateExperiment.vue

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
</template>
9898

9999
<script setup>
100-
import { ref, inject, computed, watch, onMounted } from 'vue'
100+
import { ref, inject, computed, onMounted } from 'vue'
101101
import { useLoginStore } from '@/stores/LoginStore.ts'
102102
import { useRouter, useRoute, onBeforeRouteLeave } from 'vue-router'
103103
import * as api from '@/services/dataApi'
@@ -180,11 +180,7 @@
180180
const showReturnDialog = ref(false)
181181
182182
onMounted(() => {
183-
if(route.query.snapshotId && !store.showRightDrawer) {
184-
store.showRightDrawer = true
185-
} else {
186-
getExperiment()
187-
}
183+
getExperiment()
188184
})
189185
190186
async function getExperiment() {
@@ -262,17 +258,4 @@
262258
const confirmLeave = ref(false)
263259
const toPath = ref()
264260
265-
watch(() => store.selectedSnapshot, (newVal) => {
266-
if(newVal) {
267-
experiment.value = {
268-
name: newVal.name,
269-
group: newVal.group,
270-
description: newVal.description
271-
}
272-
title.value = `View ${experiment.value.name}`
273-
} else {
274-
getExperiment()
275-
}
276-
})
277-
278261
</script>

src/frontend/src/views/QueuesFormDraftView.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -288,11 +288,7 @@ function clearForm() {
288288
289289
watch(() => store.selectedSnapshot, (q) => {
290290
if(q) {
291-
queue.value = {
292-
name: q.name,
293-
group: q.group.id,
294-
description: q.description,
295-
}
291+
queue.value = q
296292
} else {
297293
getQueue()
298294
}

src/frontend/src/views/QueuesFormView.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -311,11 +311,7 @@ const history = computed(() => {
311311
312312
watch(() => store.selectedSnapshot, (q) => {
313313
if(q) {
314-
queue.value = {
315-
name: q.name,
316-
group: q.group.id,
317-
description: q.description,
318-
}
314+
queue.value = q
319315
copyAtEditStart.value = queue.value
320316
} else {
321317
getQueue()

0 commit comments

Comments
 (0)