Skip to content

Commit 9d8d7ca

Browse files
committed
fix: F8E4M3 CUDA cast kernel name mismatch
DType::F8E4M3.as_str() returned "f8e4m3" but all CUDA kernels use "f8_e4m3" (with underscore) — e.g., cast_f8_e4m3_bf16. This caused "named symbol not found" errors for ALL F8E4M3 dtype casts on CUDA. Fix: return "f8_e4m3" from as_str(), accept both forms in from_str().
1 parent d1bd5bd commit 9d8d7ca

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

candle-core/src/dtype.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ impl std::str::FromStr for DType {
6060
"f16" => Ok(Self::F16),
6161
"f32" => Ok(Self::F32),
6262
"f64" => Ok(Self::F64),
63-
"f8e4m3" => Ok(Self::F8E4M3),
63+
"f8_e4m3" | "f8e4m3" => Ok(Self::F8E4M3),
6464
"f6e2m3" => Ok(Self::F6E2M3),
6565
"f6e3m2" => Ok(Self::F6E3M2),
6666
"f4" => Ok(Self::F4),
@@ -83,7 +83,7 @@ impl DType {
8383
Self::F16 => "f16",
8484
Self::F32 => "f32",
8585
Self::F64 => "f64",
86-
Self::F8E4M3 => "f8e4m3",
86+
Self::F8E4M3 => "f8_e4m3",
8787
Self::F6E2M3 => "f6e2m3",
8888
Self::F6E3M2 => "f6e3m2",
8989
Self::F4 => "f4",

0 commit comments

Comments
 (0)