fix: load chart correctly under Windows

utkuozdemir · utkuozdemir · commit 41e95ae434ba · 2025-02-19T16:07:46.000+01:00
The tool did not work on Windows at all because the Helm client library expects the file separator to be `/`, specifically, for the templates to be under `/templates`.

Fix it by always using forward slashes.

Signed-off-by: Utku Ozdemir &lt;utkuozdemir@gmail.com&gt;
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -13,7 +13,6 @@ on:
       - "test/**"
       - ".gitignore"
       - "docker/**"
-      - "helm/**"
       - "renovate.json"
       - ".krew.yaml"
   pull_request:
@@ -25,7 +24,6 @@ on:
       - "test/**"
       - ".gitignore"
       - "docker/**"
-      - "helm/**"
       - "renovate.json"
       - ".krew.yaml"
 
diff --git a/helm/helm.go b/helm/helm.go
@@ -58,6 +58,9 @@ func chartAsBufferedFiles() ([]*loader.BufferedFile, error) {
 			return fmt.Errorf("failed to relativize path %q: %w", path, err)
 		}
 
+		// fix for Windows - the Helm client library expects templates to be under "templates/", i.e., with forward-slash
+		relativePath = filepath.ToSlash(relativePath)
+
 		files = append(files, &loader.BufferedFile{
 			Name: relativePath,
 			Data: data,

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,9 @@ func chartAsBufferedFiles() ([]*loader.BufferedFile, error) {`
`58`	`58`	`return fmt.Errorf("failed to relativize path %q: %w", path, err)`
`59`	`59`	`}`
`60`	`60`
	`61`	`+ // fix for Windows - the Helm client library expects templates to be under "templates/", i.e., with forward-slash`
	`62`	`+ relativePath = filepath.ToSlash(relativePath)`
	`63`	`+`
`61`	`64`	`files = append(files, &loader.BufferedFile{`
`62`	`65`	`Name: relativePath,`
`63`	`66`	`Data: data,`