feat: use pv-migrate version as the helm chart version

So the manifests on the cluster would clearly reflect the pv-migrate version.

Signed-off-by: Utku Ozdemir <utkuozdemir@gmail.com>

Author: utkuozdemir

Taskfile.yml

@@ -8,7 +8,9 @@ tasks:
         sh: head -n 1 go.mod | cut -d' ' -f2
     cmds:
       - go mod tidy
+      - go fix ./...
       - golangci-lint run --fix ./...
+      - golangci-lint fmt ./...
       - shfmt -l -i 2 -ci -sr -w .
 
   lint:

integration/integration_test.go

@@ -80,7 +80,7 @@ var (
 		"cat /volume/restricted_dir/hidden.txt"
 
 	clearRestrictedDataShellCommand = "rm -f /volume/root_only.txt && rm -rf /volume/restricted_dir"
-	generateExtraDataShellCommand = fmt.Sprintf("echo -n %s > %s",
+	generateExtraDataShellCommand   = fmt.Sprintf("echo -n %s > %s",
 		generateDataContent, extraDataFilePath)
 	printDataUIDGIDContentShellCommand = fmt.Sprintf(
 		"stat -c '%%u' %s && stat -c '%%g' %s && cat %s",
@@ -336,7 +336,15 @@ func testCustomRsyncArgs(t *testing.T) {
 	require.NoError(t, err)
 
 	cmdArgs := strings.Fields(fmt.Sprintf("%s -i -n %s -N %s", defaultHelmArgs(t), ns1, ns1))
-	cmdArgs = append(cmdArgs, "--helm-set", "rsync.extraArgs=--partial --inplace --sparse", "--source", "source", "--dest", "dest")
+	cmdArgs = append(
+		cmdArgs,
+		"--helm-set",
+		"rsync.extraArgs=--partial --inplace --sparse",
+		"--source",
+		"source",
+		"--dest",
+		"dest",
+	)
 
 	require.NoError(t, runCliAppWithArgs(ctx, t, cmdArgs...))
 
@@ -365,7 +373,12 @@ func testSameNSLoadBalancer(t *testing.T) {
 	_, err := execInPod(ctx, mainClusterCli, ns1, "dest", generateExtraDataShellCommand)
 	require.NoError(t, err)
 
-	cmd := fmt.Sprintf("%s -s loadbalancer -i -n %s -N %s --loadbalancer-timeout 5m --source source --dest dest", defaultHelmArgs(t), ns1, ns1)
+	cmd := fmt.Sprintf(
+		"%s -s loadbalancer -i -n %s -N %s --loadbalancer-timeout 5m --source source --dest dest",
+		defaultHelmArgs(t),
+		ns1,
+		ns1,
+	)
 	require.NoError(t, runCliApp(ctx, t, cmd))
 
 	stdout, err := execInPod(ctx, mainClusterCli, ns1, "dest", printDataUIDGIDContentShellCommand)

internal/app/migrate.go

@@ -17,18 +17,35 @@ import (
 	"github.com/utkuozdemir/pv-migrate/pvmigrate"
 )
 
+// isReleaseVersion reports whether version looks like a real GoReleaser release
+// (e.g. "2.3.0", "2.3.0-rc.1") as opposed to a dev or snapshot build.
+func isReleaseVersion(version string) bool {
+	return version != "" && !strings.Contains(version, "SNAPSHOT") && !strings.Contains(version, "dev")
+}
+
 // releaseImageTag returns the version as an image tag suitable for Docker images.
 // GoReleaser sets version without the "v" prefix (e.g. "2.3.0", "2.3.0-rc.1",
 // "2.2.1-SNAPSHOT-43a0f03"), while local builds default to "dev".
 // Returns empty string for dev and snapshot builds.
 func releaseImageTag(version string) string {
-	if version == "" || strings.Contains(version, "SNAPSHOT") || strings.Contains(version, "dev") {
+	if !isReleaseVersion(version) {
 		return ""
 	}
 
 	return "v" + version
 }
 
+// releaseChartVersion returns the version for the embedded Helm chart metadata.
+// Returns empty string for dev and snapshot builds, letting the chart's built-in
+// version (0.0.0) remain unchanged.
+func releaseChartVersion(version string) string {
+	if !isReleaseVersion(version) {
+		return ""
+	}
+
+	return version
+}
+
 const (
 	FlagLogLevel  = "log-level"
 	FlagLogFormat = "log-format"
@@ -99,6 +116,7 @@ func BuildMigrateCmd(ctx context.Context, version, commit, date string, logger *
 	var migration pvmigrate.Migration
 
 	migration.ImageTag = releaseImageTag(version)
+	migration.ChartVersion = releaseChartVersion(version)
 	migration.ApplyDefaults()
 	migration.ShowProgressBar = isATTY
 

internal/app/release_image_tag_test.go

@@ -40,3 +40,25 @@ func TestReleaseImageTag(t *testing.T) {
 		})
 	}
 }
+
+func TestReleaseChartVersion(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		version  string
+		expected string
+	}{
+		{"2.3.0", "2.3.0"},
+		{"2.3.0-rc.1", "2.3.0-rc.1"},
+		{"2.2.1-SNAPSHOT-43a0f03", ""},
+		{"dev", ""},
+		{"", ""},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.version, func(t *testing.T) {
+			t.Parallel()
+			assert.Equal(t, tt.expected, releaseChartVersion(tt.version))
+		})
+	}
+}

internal/helm/helm.go

@@ -22,8 +22,9 @@ var chartFS embed.FS
 
 const rootDir = "pv-migrate"
 
-// LoadChart loads the embedded Helm chart.
-func LoadChart() (*chart.Chart, error) {
+// LoadChart loads the embedded Helm chart, overriding the chart metadata version
+// with the provided version string if non-empty.
+func LoadChart(version string) (*chart.Chart, error) {
 	files, err := chartAsBufferedFiles()
 	if err != nil {
 		return nil, fmt.Errorf("failed to get chart files: %w", err)
@@ -34,6 +35,11 @@ func LoadChart() (*chart.Chart, error) {
 		return nil, fmt.Errorf("failed to load chart: %w", err)
 	}
 
+	if version != "" {
+		helmChart.Metadata.Version = version
+		helmChart.Metadata.AppVersion = version
+	}
+
 	return helmChart, nil
 }
 

internal/helm/helm_test.go

@@ -12,11 +12,21 @@ import (
 func TestLoadChart(t *testing.T) {
 	t.Parallel()
 
-	chart, err := helm.LoadChart()
+	chart, err := helm.LoadChart("")
 	require.NoError(t, err)
 
 	assert.Equal(t, "pv-migrate", chart.Metadata.Name)
 	assert.NotEmpty(t, chart.Metadata.Version, "chart version should not be empty")
 	assert.NotEmpty(t, chart.Values, "chart values should not be empty")
 	assert.NotEmpty(t, chart.Templates, "chart templates should not be empty")
 }
+
+func TestLoadChartVersionOverride(t *testing.T) {
+	t.Parallel()
+
+	chart, err := helm.LoadChart("1.2.3")
+	require.NoError(t, err)
+
+	assert.Equal(t, "1.2.3", chart.Metadata.Version)
+	assert.Equal(t, "1.2.3", chart.Metadata.AppVersion)
+}

internal/helm/pv-migrate/Chart.yaml

@@ -2,8 +2,8 @@ apiVersion: v2
 name: pv-migrate
 description: The helm chart of pv-migrate
 type: application
-version: 0.5.0
-appVersion: 0.5.0
+version: 0.0.0
+appVersion: 0.0.0
 home: https://github.com/utkuozdemir/pv-migrate
 keywords:
   - pv-migrate

internal/helm/pv-migrate/README.md

@@ -1,6 +1,6 @@
 # pv-migrate
 
-![Version: 0.5.0](https://img.shields.io/badge/Version-0.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.5.0](https://img.shields.io/badge/AppVersion-0.5.0-informational?style=flat-square)
+![Version: 0.0.0](https://img.shields.io/badge/Version-0.0.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.0.0](https://img.shields.io/badge/AppVersion-0.0.0-informational?style=flat-square)
 
 The helm chart of pv-migrate
 

internal/migration/types.go

@@ -19,6 +19,7 @@ type PVCInfo struct {
 
 type Request struct {
 	ImageTag              string
+	ChartVersion          string
 	Source                PVCInfo
 	Dest                  PVCInfo
 	DeleteExtraneousFiles bool

internal/migrator/migrator.go

@@ -94,7 +94,7 @@ func (m *Migrator) Run(ctx context.Context, request *migration.Request, logger *
 func (m *Migrator) buildMigration(ctx context.Context, request *migration.Request,
 	logger *slog.Logger,
 ) (*migration.Migration, error) {
-	chart, err := helm.LoadChart()
+	chart, err := helm.LoadChart(request.ChartVersion)
 	if err != nil {
 		return nil, fmt.Errorf("failed to load helm chart: %w", err)
 	}