docs(plans): revise v0.6.2 plan per subagent review (1 Crit, 3 Imp, 2 Min)

Reviewer subagent findings applied:
- Critical: Task 4 single-char test dropped the onQueryChange assertion
  (clearedRef initial state made it fire nothing on empty→1char
  transition); test now only asserts api.search is not called.
- Important: Task 5 TagSidebarProps.mode made optional with default
  "all"; destructuring adds `mode = "all"` so existing tests (which
  don't pass mode) still pass TypeScript.
- Important: Task 6 import snippet no longer re-imports SearchHit
  (already in current App.tsx line 11; duplicate would fail
  no-duplicate-imports ESLint rule).
- Important: Task 6 explicitly instructs removal of the old `counts`
  derivation block (lines 162-167) to prevent unused-variable
  lint error under `eslint -D warnings`.
- Minor: Task 6 expected test count corrected 26→22 (search.test has
  9+4+9 after Tasks 1-3).
- Minor: Task 8 close-issue comment uses current spec hash 92f520f
  instead of stale bc451d8.

Plan now ready for execution.

Author: utof

docs/superpowers/plans/2026-04-17-v0.6.2-live-faceted-search.md

@@ -580,8 +580,11 @@ describe("SearchBar", () => {
     });
     await advanceAndFlush(300);
 
+    // The purpose of this test is to confirm no search fires.
+    // Whether onQueryChange fires (""/null) on the empty→"a" transition
+    // is covered by clear-signal tests below; here we only pin that
+    // `api.search` stays untouched for single-char input.
     expect(mockSearch).not.toHaveBeenCalled();
-    expect(onChange).toHaveBeenCalledWith("", null);
   });
 
   it("fires search for two-character query at limit 500", async () => {
@@ -965,12 +968,13 @@ interface TagSidebarProps {
   selectedTagId: string | null;
   onSelect: (tagId: string | null) => void;
   /**
-   * Rendering mode:
-   * - "all": show every tag in `tags` (default — no search active).
+   * Rendering mode (optional; defaults to "all" so existing callers
+   * that don't pass this prop continue to work):
+   * - "all": show every tag in `tags` (no search active).
    * - "facets": show only tags with counts > 0 (search active; the
    *   sidebar becomes a facet panel over the current results).
    */
-  mode: "all" | "facets";
+  mode?: "all" | "facets";
 }
 
 /**
@@ -984,7 +988,7 @@ export default function TagSidebar({
   totalCount,
   selectedTagId,
   onSelect,
-  mode,
+  mode = "all",
 }: TagSidebarProps) {
   const visibleTags =
     mode === "facets"
@@ -1179,9 +1183,20 @@ Add imports at the top:
 
 ```typescript
 import { composeVisible, computeFacets, sortByRank } from "./lib/search";
-import type { SearchHit } from "./types";
 ```
 
+(Do NOT re-import `SearchHit` — it is already imported in the current
+`App.tsx` line 11 as part of the existing `import type {
+FileWithTags, ScanResult, SearchHit, Tag } from "./types";` line.
+Adding a duplicate import would fail ESLint's `no-duplicate-imports`
+rule and break `just ci`.)
+
+**Also REMOVE the existing `counts` derivation block** (App.tsx
+lines 162-167 in current state — the block starting with
+`// Compute per-tag file counts from the full unfiltered list.`).
+The new `facetCounts` replaces it; leaving the old block in produces
+an unused-variable lint error under `eslint -D warnings`, failing CI.
+
 - [ ] **Step 6.3: Run App.test.tsx — confirm existing tests still pass**
 
 ```bash
@@ -1196,7 +1211,7 @@ Expected: PASS — both existing tests still green (file-event debounce + watche
 cd apps/desktop && bun run test
 ```
 
-Expected: PASS — everything green (26 tests in search.test, 8 in SearchBar, 9 in TagSidebar, 2 in App, plus all unchanged suites).
+Expected: PASS — everything green (22 tests in search.test, 8 in SearchBar, 9 in TagSidebar, 2 in App, plus all unchanged suites).
 
 - [ ] **Step 6.5: Commit**
 
@@ -1528,7 +1543,7 @@ Actions for the release-plz workflow status.
 - [ ] **Step 8.7: Close issue #25 + link #32**
 
 ```bash
-gh issue close 25 --comment "Closed by v0.6.2 — live faceted search. See release notes + commit bc451d8 (spec) + the feat/fix commits in the v0.6.1..v0.6.2 range."
+gh issue close 25 --comment "Closed by v0.6.2 — live faceted search. See release notes + commit 92f520f (spec) + the feat/fix commits in the v0.6.1..v0.6.2 range."
 gh issue comment 32 --body "v0.6.2 ships the core of this issue — live inline narrowing + facet panel + AND composition with tag filter. Remaining sub-items (multi-tag OR, full-corpus facet counts, advanced query DSL) remain tracked here as post-v1."
 ```