Commit 846c596
committed
ci(windows): force ~/.cargo/bin onto GITHUB_PATH after binstall
Windows ci.yml run 24929261378 (commit 0889fbb) failed at `Run just ci`
with `just: command not found` despite cargo-binstall logging
"v1.50.0 is already installed". Root cause: the rustup-init step's
`echo $CARGO_HOME\bin >> $GITHUB_PATH` line is gated behind
`command -v rustup`, which always succeeds on windows-latest (rustup
pre-installed). When Swatinem rust-cache partial-restores ~/.cargo/bin
containing a previously-installed just.exe, binstall skips install AND
its PATH side-effect — leaving bash steps unable to find just.exe even
though it's on disk.
Forcing $env:GITHUB_PATH after binstall is unconditional and idempotent.
Reverts to the prior latent-flakiness state if the upstream rustup-init
gate is fixed.
Independent of the fuzz/bench fixes in 0889fbb — that commit only
modified fuzz.yml + 2 Cargo.toml files; the Windows breakage was a
pre-existing race that finally hit on this push's cache-state shuffle.1 parent 0889fbb commit 846c596
1 file changed
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
70 | 82 | | |
71 | 83 | | |
72 | 84 | | |
| |||
0 commit comments