fix(pack): align node target watcher detection

Author: fireairforce

packages/pack/package.json

@@ -42,6 +42,7 @@
     "@hono/node-ws": "^1.3.0",
     "@swc/helpers": "0.5.15",
     "@utoo/pack-shared": "*",
+    "browserslist": "^4.28.5",
     "domparser-rs": "^0.0.7",
     "find-up": "4.1.0",
     "get-port": "5.1.1",

packages/pack/src/__test__/serveServerOutputsHmrChild.ts

@@ -94,7 +94,7 @@ async function main() {
     scenario === "dist-root"
       ? {
           entry: [{ import: "./src/index.js", name: "main" }],
-          target: "node",
+          target: "current node",
           output: { path: "./dist/node", clean: true },
         }
       : {

packages/pack/src/core/hmr.ts

@@ -27,6 +27,7 @@ import { processHtmlEntry } from "../utils/htmlEntry";
 import { acquirePersistentCacheLock } from "../utils/lockfile";
 import { normalizePath } from "../utils/normalizePath";
 import { useWorkerThreads } from "../utils/runtimePluginStratety";
+import { isNodeTarget } from "../utils/target";
 import { validateEntryPaths } from "../utils/validateEntry";
 import { consumeHmrSubscription } from "./hmrSubscription";
 import { projectFactory } from "./project";
@@ -178,11 +179,7 @@ export async function createHotReloader(
       bundleOptions.config.server?.entry ||
         bundleOptions.config.server?.function,
     ),
-    // The Rust config treats the common `node`/`node <version>` forms as Node.
-    // Other browserslist queries remain Web targets.
-    nodeTarget: /^node(?:\s|$)/i.test(
-      bundleOptions.config.target?.trim() ?? "",
-    ),
+    nodeTarget: isNodeTarget(bundleOptions.config.target),
   });
   const persistentCaching = isPersistentCachingEnabled(
     bundleOptions.config.persistentCaching,

packages/pack/src/utils/target.test.ts

@@ -0,0 +1,22 @@
+import { describe, expect, it } from "vitest";
+import { isNodeTarget } from "./target";
+
+describe("isNodeTarget", () => {
+  it.each(["node", "current node", "maintained node versions", "node >= 20"])(
+    "recognizes the Node target %s",
+    (target) => {
+      expect(isNodeTarget(target)).toBe(true);
+    },
+  );
+
+  it.each([undefined, "web", "last 1 Chrome versions"])(
+    "keeps the web target %s on the client watcher",
+    (target) => {
+      expect(isNodeTarget(target)).toBe(false);
+    },
+  );
+
+  it("matches the first resolved distribution for mixed queries", () => {
+    expect(isNodeTarget("last 1 Chrome versions, current node")).toBe(false);
+  });
+});

packages/pack/src/utils/target.ts

@@ -0,0 +1,16 @@
+import browserslist from "browserslist";
+
+export function isNodeTarget(target?: string) {
+  if (target === undefined) return false;
+
+  try {
+    const [distribution] = browserslist(target.split(","), {
+      ignoreUnknownVersions: true,
+    });
+    return distribution?.startsWith("node ") ?? false;
+  } catch {
+    // Match Config::platform(): `node` is also the explicit fallback when the
+    // target isn't a valid Browserslist query.
+    return target === "node";
+  }
+}