Bugfix/pool arrays resize engine calls (#320)

* test resize and set for pool arrays

* Replace calls to remove when calling resize engine calls on pool arrays

Co-authored-by: Richard Treier <richard.treier@gmail.com>

Author: piiertho

harness/tests/src/main/kotlin/godot/tests/Invocation.kt

@@ -10,6 +10,19 @@ func test_pool_byte_array_add_delete() -> void:
 	assert_eq(invocation_script.pool_byte_array.size(), 3, "PoolByteArray have 3 elements")
 	invocation_script.delete_byte_from_pool_array(0)
 	assert_eq(invocation_script.pool_byte_array.size(), 2, "PoolByteArray have 2 elements")
+
+	# Test resize + set in particular
+	invocation_script.resize_byte_pool_array(0)
+	assert_eq(invocation_script.pool_byte_array.size(), 0, "PoolByteArray was emptied by resize(0)")
+	invocation_script.resize_byte_pool_array(3)
+	invocation_script.set_byte_in_pool_array(0, 1)
+	invocation_script.set_byte_in_pool_array(1, 2)
+	invocation_script.set_byte_in_pool_array(2, 3)
+	assert_eq(invocation_script.pool_byte_array.size(), 3, "PoolByteArray has size 3 after resize(3) and 3x set(...)")
+	assert_eq(invocation_script.get_byte_from_pool_array(0), 1, "First element of PoolByteArray after resize(3) and 3x set(...) should be 1.")
+	assert_eq(invocation_script.get_byte_from_pool_array(1), 2, "Second element of PoolByteArray after resize(3) and 3x set(...) should be 2.")
+	assert_eq(invocation_script.get_byte_from_pool_array(2), 3, "Third element of PoolByteArray after resize(3) and 3x set(...) should be 3.")
+
 	invocation_script.free()
 
 func test_pool_color_array_add_delete() -> void:
@@ -24,6 +37,19 @@ func test_pool_color_array_add_delete() -> void:
 	assert_eq(invocation_script.get_color_from_pool_array(2), Color(1, 2, 3), "Second element of PoolColorArray should be Color(1, 2, 3).")
 	invocation_script.delete_color_from_pool_array(0)
 	assert_eq(invocation_script.pool_color_array.size(), 2, "PoolColorArray have 2 elements")
+
+	# Test resize + set in particular
+	invocation_script.resize_color_pool_array(0)
+	assert_eq(invocation_script.pool_color_array.size(), 0, "PoolColorArray was emptied by resize(0)")
+	invocation_script.resize_color_pool_array(3)
+	invocation_script.set_color_in_pool_array(0, Color(1, 1, 9))
+	invocation_script.set_color_in_pool_array(1, Color(2, 2, 9))
+	invocation_script.set_color_in_pool_array(2, Color(3, 3, 9))
+	assert_eq(invocation_script.pool_color_array.size(), 3, "PoolColorArray has size 3 after resize(3) and 3x set(...)")
+	assert_eq(invocation_script.get_color_from_pool_array(0), Color(1, 1, 9), "First element of PoolColorArray after resize(3) and 3x set(...) should be Color(1, 1, 9).")
+	assert_eq(invocation_script.get_color_from_pool_array(1), Color(2, 2, 9), "Second element of PoolColorArray after resize(3) and 3x set(...) should be Color(2, 2, 9).")
+	assert_eq(invocation_script.get_color_from_pool_array(2), Color(3, 3, 9), "Third element of PoolColorArray after resize(3) and 3x set(...) should be Color(3, 3, 9).")
+
 	invocation_script.free()
 
 func test_pool_int_array_add_delete() -> void:
@@ -38,6 +64,19 @@ func test_pool_int_array_add_delete() -> void:
 	assert_eq(invocation_script.get_int_from_pool_array(2), 3, "Second element of PoolIntArray should be 3.")
 	invocation_script.delete_int_from_pool_array(0)
 	assert_eq(invocation_script.pool_int_array.size(), 2, "PoolIntArray have 2 elements")
+
+	# Test resize + set in particular
+	invocation_script.resize_int_pool_array(0)
+	assert_eq(invocation_script.pool_int_array.size(), 0, "PoolIntArray was emptied by resize(0)")
+	invocation_script.resize_int_pool_array(3)
+	invocation_script.set_int_in_pool_array(0, 1)
+	invocation_script.set_int_in_pool_array(1, 2)
+	invocation_script.set_int_in_pool_array(2, 3)
+	assert_eq(invocation_script.pool_int_array.size(), 3, "PoolIntArray has size 3 after resize(3) and 3x set(...)")
+	assert_eq(invocation_script.get_int_from_pool_array(0), 1, "First element of PoolIntArray after resize(3) and 3x set(...) should be 1.")
+	assert_eq(invocation_script.get_int_from_pool_array(1), 2, "Second element of PoolIntArray after resize(3) and 3x set(...) should be 2.")
+	assert_eq(invocation_script.get_int_from_pool_array(2), 3, "Third element of PoolIntArray after resize(3) and 3x set(...) should be 3.")
+
 	invocation_script.free()
 
 func test_pool_real_array_add_delete() -> void:
@@ -52,6 +91,19 @@ func test_pool_real_array_add_delete() -> void:
 	assert_eq(invocation_script.get_real_from_pool_array(2), 3.0, "Second element of PoolRealArray should be 3.0.")
 	invocation_script.delete_real_from_pool_array(0)
 	assert_eq(invocation_script.pool_real_array.size(), 2, "PoolRealArray have 2 elements")
+
+	# Test resize + set in particular
+	invocation_script.resize_real_pool_array(0)
+	assert_eq(invocation_script.pool_real_array.size(), 0, "PoolRealArray was emptied by resize(0)")
+	invocation_script.resize_real_pool_array(3)
+	invocation_script.set_real_in_pool_array(0, 1.0)
+	invocation_script.set_real_in_pool_array(1, 2.0)
+	invocation_script.set_real_in_pool_array(2, 3.0)
+	assert_eq(invocation_script.pool_real_array.size(), 3, "PoolRealArray has size 3 after resize(3) and 3x set(...)")
+	assert_eq(invocation_script.get_real_from_pool_array(0), 1.0, "First element of PoolRealArray after resize(3) and 3x set(...) should be 1.0.")
+	assert_eq(invocation_script.get_real_from_pool_array(1), 2.0, "Second element of PoolRealArray after resize(3) and 3x set(...) should be 2.0.")
+	assert_eq(invocation_script.get_real_from_pool_array(2), 3.0, "Third element of PoolRealArray after resize(3) and 3x set(...) should be 3.0.")
+
 	invocation_script.free()
 
 func test_pool_string_array_add_delete() -> void:
@@ -66,6 +118,19 @@ func test_pool_string_array_add_delete() -> void:
 	assert_eq(invocation_script.get_string_from_pool_array(2), "3", "Second element of PoolStringArray should be 3.")
 	invocation_script.delete_string_from_pool_array(0)
 	assert_eq(invocation_script.pool_string_array.size(), 2, "PoolStringArray have 2 elements")
+
+	# Test resize + set in particular
+	invocation_script.resize_string_pool_array(0)
+	assert_eq(invocation_script.pool_string_array.size(), 0, "PoolStringArray was emptied by resize(0)")
+	invocation_script.resize_string_pool_array(3)
+	invocation_script.set_string_in_pool_array(0, "1")
+	invocation_script.set_string_in_pool_array(1, "2")
+	invocation_script.set_string_in_pool_array(2, "3")
+	assert_eq(invocation_script.pool_string_array.size(), 3, "PoolStringArray has size 3 after resize(3) and 3x set(...)")
+	assert_eq(invocation_script.get_string_from_pool_array(0), "1", "First element of PoolStringArray after resize(3) and 3x set(...) should be 1.")
+	assert_eq(invocation_script.get_string_from_pool_array(1), "2", "Second element of PoolStringArray after resize(3) and 3x set(...) should be 2.")
+	assert_eq(invocation_script.get_string_from_pool_array(2), "3", "Third element of PoolStringArray after resize(3) and 3x set(...) should be 3.")
+
 	invocation_script.free()
 
 func test_pool_vector2_array_add_delete() -> void:
@@ -80,6 +145,19 @@ func test_pool_vector2_array_add_delete() -> void:
 	assert_eq(invocation_script.get_vector2_from_pool_array(2), Vector2(3, 1), "Second element of PoolVector2Array should be Vector2(3, 1).")
 	invocation_script.delete_vector2_from_pool_array(0)
 	assert_eq(invocation_script.pool_vector2_array.size(), 2, "PoolVector2Array have 2 elements")
+
+	# Test resize + set in particular
+	invocation_script.resize_vector2_pool_array(0)
+	assert_eq(invocation_script.pool_vector2_array.size(), 0, "PoolVector2Array was emptied by resize(0)")
+	invocation_script.resize_vector2_pool_array(3)
+	invocation_script.set_vector2_in_pool_array(0, Vector2(1, 1))
+	invocation_script.set_vector2_in_pool_array(1, Vector2(2, 2))
+	invocation_script.set_vector2_in_pool_array(2, Vector2(3, 3))
+	assert_eq(invocation_script.pool_vector2_array.size(), 3, "PoolVector2Array has size 3 after resize(3) and 3x set(...)")
+	assert_eq(invocation_script.get_vector2_from_pool_array(0), Vector2(1, 1), "First element of PoolVector2Array after resize(3) and 3x set(...) should be Vector2(1, 1).")
+	assert_eq(invocation_script.get_vector2_from_pool_array(1), Vector2(2, 2), "Second element of PoolVector2Array after resize(3) and 3x set(...) should be Vector2(2, 2).")
+	assert_eq(invocation_script.get_vector2_from_pool_array(2), Vector2(3, 3), "Third element of PoolVector2Array after resize(3) and 3x set(...) should be Vector2(3, 3).")
+
 	invocation_script.free()
 
 func test_pool_vector3_array_add_delete() -> void:
@@ -94,6 +172,19 @@ func test_pool_vector3_array_add_delete() -> void:
 	assert_eq(invocation_script.get_vector3_from_pool_array(2), Vector3(3, 1, 1), "Second element of PoolVector3Array should be Vector3(3, 1).")
 	invocation_script.delete_vector3_from_pool_array(0)
 	assert_eq(invocation_script.pool_vector3_array.size(), 2, "PoolVector3Array have 2 elements")
+
+	# Test resize + set in particular
+	invocation_script.resize_vector3_pool_array(0)
+	assert_eq(invocation_script.pool_vector3_array.size(), 0, "PoolVector3Array was emptied by resize(0)")
+	invocation_script.resize_vector3_pool_array(3)
+	invocation_script.set_vector3_in_pool_array(0, Vector3(1, 1, 9))
+	invocation_script.set_vector3_in_pool_array(1, Vector3(2, 2, 9))
+	invocation_script.set_vector3_in_pool_array(2, Vector3(3, 3, 9))
+	assert_eq(invocation_script.pool_vector3_array.size(), 3, "PoolVector3Array has size 3 after resize(3) and 3x set(...)")
+	assert_eq(invocation_script.get_vector3_from_pool_array(0), Vector3(1, 1, 9), "First element of PoolVector3Array after resize(3) and 3x set(...) should be Vector3(1, 1, 9).")
+	assert_eq(invocation_script.get_vector3_from_pool_array(1), Vector3(2, 2, 9), "Second element of PoolVector3Array after resize(3) and 3x set(...) should be Vector3(2, 2, 9).")
+	assert_eq(invocation_script.get_vector3_from_pool_array(2), Vector3(3, 3, 9), "Third element of PoolVector3Array after resize(3) and 3x set(...) should be Vector3(3, 3, 9).")
+
 	invocation_script.free()
 
 func test_pool_byte_array_string_conversion() -> void:

harness/tests/test/unit/test_pool_arrays.gd

@@ -262,7 +262,7 @@ void PoolByteArrayBridge::engine_call_resize(JNIEnv* p_raw_env, jobject p_instan
     Variant args[1] = {};
     TransferContext* transfer_context{GDKotlin::get_instance().transfer_context};
     transfer_context->read_args(env, args);
-    from_uint_to_ptr<PoolByteArray>(p_raw_ptr)->remove(args[0].operator unsigned int());
+    from_uint_to_ptr<PoolByteArray>(p_raw_ptr)->resize(args[0].operator unsigned int());
 }
 
 void PoolByteArrayBridge::engine_call_set(JNIEnv* p_raw_env, jobject p_instance, jlong p_raw_ptr) {

src/bridges/pool_byte_array_bridge.cpp

@@ -159,7 +159,7 @@ void PoolColorArrayBridge::engine_call_resize(JNIEnv* p_raw_env, jobject p_insta
     Variant args[1] = {};
     TransferContext* transfer_context{GDKotlin::get_instance().transfer_context};
     transfer_context->read_args(env, args);
-    from_uint_to_ptr<PoolColorArray>(p_raw_ptr)->remove(args[0].operator unsigned int());
+    from_uint_to_ptr<PoolColorArray>(p_raw_ptr)->resize(args[0].operator unsigned int());
 }
 
 void PoolColorArrayBridge::engine_call_set(JNIEnv* p_raw_env, jobject p_instance, jlong p_raw_ptr) {

src/bridges/pool_color_array_bridge.cpp

@@ -159,7 +159,7 @@ void PoolIntArrayBridge::engine_call_resize(JNIEnv* p_raw_env, jobject p_instanc
     Variant args[1] = {};
     TransferContext* transfer_context{GDKotlin::get_instance().transfer_context};
     transfer_context->read_args(env, args);
-    from_uint_to_ptr<PoolIntArray>(p_raw_ptr)->remove(args[0].operator unsigned int());
+    from_uint_to_ptr<PoolIntArray>(p_raw_ptr)->resize(args[0].operator unsigned int());
 }
 
 void PoolIntArrayBridge::engine_call_set(JNIEnv* p_raw_env, jobject p_instance, jlong p_raw_ptr) {

src/bridges/pool_int_array_bridge.cpp

@@ -159,7 +159,7 @@ void PoolRealArrayBridge::engine_call_resize(JNIEnv* p_raw_env, jobject p_instan
     Variant args[1] = {};
     TransferContext* transfer_context{GDKotlin::get_instance().transfer_context};
     transfer_context->read_args(env, args);
-    from_uint_to_ptr<PoolRealArray>(p_raw_ptr)->remove(args[0].operator unsigned int());
+    from_uint_to_ptr<PoolRealArray>(p_raw_ptr)->resize(args[0].operator unsigned int());
 }
 
 void PoolRealArrayBridge::engine_call_set(JNIEnv* p_raw_env, jobject p_instance, jlong p_raw_ptr) {

src/bridges/pool_real_array_bridge.cpp

@@ -174,7 +174,7 @@ void PoolStringArrayBridge::engine_call_resize(JNIEnv* p_raw_env, jobject p_inst
     Variant args[1] = {};
     TransferContext* transfer_context{GDKotlin::get_instance().transfer_context};
     transfer_context->read_args(env, args);
-    from_uint_to_ptr<PoolStringArray>(p_raw_ptr)->remove(args[0].operator unsigned int());
+    from_uint_to_ptr<PoolStringArray>(p_raw_ptr)->resize(args[0].operator unsigned int());
 }
 
 void PoolStringArrayBridge::engine_call_set(JNIEnv* p_raw_env, jobject p_instance, jlong p_raw_ptr) {

src/bridges/pool_string_array_bridge.cpp

@@ -159,7 +159,7 @@ void PoolVector2ArrayBridge::engine_call_resize(JNIEnv* p_raw_env, jobject p_ins
     Variant args[1] = {};
     TransferContext* transfer_context{GDKotlin::get_instance().transfer_context};
     transfer_context->read_args(env, args);
-    from_uint_to_ptr<PoolVector2Array>(p_raw_ptr)->remove(args[0].operator unsigned int());
+    from_uint_to_ptr<PoolVector2Array>(p_raw_ptr)->resize(args[0].operator unsigned int());
 }
 
 void PoolVector2ArrayBridge::engine_call_set(JNIEnv* p_raw_env, jobject p_instance, jlong p_raw_ptr) {

src/bridges/pool_vector2_array_bridge.cpp

@@ -159,7 +159,7 @@ void PoolVector3ArrayBridge::engine_call_resize(JNIEnv* p_raw_env, jobject p_ins
     Variant args[1] = {};
     TransferContext* transfer_context{GDKotlin::get_instance().transfer_context};
     transfer_context->read_args(env, args);
-    from_uint_to_ptr<PoolVector3Array>(p_raw_ptr)->remove(args[0].operator unsigned int());
+    from_uint_to_ptr<PoolVector3Array>(p_raw_ptr)->resize(args[0].operator unsigned int());
 }
 
 void PoolVector3ArrayBridge::engine_call_set(JNIEnv* p_raw_env, jobject p_instance, jlong p_raw_ptr) {