Enhanced main.py with forgot-password OTP and auto DB creation

Author: Uttam Singh

backend/app/main.py

@@ -1,26 +1,25 @@
-from fastapi import FastAPI, UploadFile, File, Depends, HTTPException, Form
+from fastapi import FastAPI, UploadFile, File, Depends, HTTPException
 from fastapi.middleware.cors import CORSMiddleware
 from sqlalchemy import create_engine, Column, Integer, String, Date, Text
 from sqlalchemy.orm import sessionmaker, declarative_base, Session
-from pydantic import BaseModel
 from datetime import date
-import os, shutil
 from dotenv import load_dotenv
+from pydantic import BaseModel
+import os, shutil
 
-# ==============================
-# 1️⃣ Load environment variables
-# ==============================
+# ================================================
+# 1️⃣ Load Environment Variables & Database Setup
+# ================================================
 load_dotenv()
 
 DATABASE_URL = os.getenv("DATABASE_URL", "sqlite:///./app.db")
 engine = create_engine(DATABASE_URL, pool_pre_ping=True)
 SessionLocal = sessionmaker(autocommit=False, autoflush=False, bind=engine)
 Base = declarative_base()
 
-
-# ==============================
-# 2️⃣ Database models (Tasks, Audit Logs)
-# ==============================
+# ================================================
+# 2️⃣ Local Models for Internal Tables (Task + Audit Log)
+# ================================================
 class Task(Base):
     __tablename__ = "tasks"
     id = Column(Integer, primary_key=True, index=True)
@@ -41,16 +40,12 @@ class AuditLog(Base):
     detail = Column(Text)
 
 
-# ✅ Create all tables initially (will also be re-created by /create-db)
-Base.metadata.create_all(bind=engine)
-
-
-# ==============================
-# 3️⃣ FastAPI app setup
-# ==============================
+# ================================================
+# 3️⃣ FastAPI App Initialization
+# ================================================
 app = FastAPI(title="FAT-EIBL (Edme) – API")
 
-# ✅ Enable CORS for frontend
+# Enable CORS for the frontend
 allow = os.getenv("ALLOW_ORIGINS", "*").split(",")
 app.add_middleware(
     CORSMiddleware,
@@ -60,44 +55,41 @@ class AuditLog(Base):
     allow_headers=["*"],
 )
 
-
-# ==============================
-# 4️⃣ Database dependency
-# ==============================
+# ================================================
+# 4️⃣ Database Dependency
+# ================================================
 def get_db():
     db = SessionLocal()
     try:
         yield db
     finally:
         db.close()
 
-
-# ==============================
-# 5️⃣ Import Routers (User + Forgot Password)
-# ==============================
+# ================================================
+# 5️⃣ Import Routers (Users, Forgot Password)
+# ================================================
 from app.routers import users, forgot_password
 
 app.include_router(users.router, prefix="/users", tags=["Users"])
 app.include_router(forgot_password.router, prefix="/users", tags=["Forgot Password"])
 
-
-# ==============================
-# 6️⃣ Health check
-# ==============================
+# ================================================
+# 6️⃣ Health Check Endpoint
+# ================================================
 @app.get("/health")
-def health():
-    return {"status": "ok", "message": "Backend is running"}
-
+def health_check():
+    """Simple endpoint to verify backend health"""
+    return {"status": "ok", "message": "Backend is running properly"}
 
-# ==============================
-# 7️⃣ File Uploads (optional)
-# ==============================
+# ================================================
+# 7️⃣ File Upload Handler (Optional)
+# ================================================
 UPLOAD_DIR = os.path.join(os.getcwd(), "uploads")
 os.makedirs(UPLOAD_DIR, exist_ok=True)
 
-
 @app.post("/upload/{task_id}")
 async def upload_file(task_id: int, file: UploadFile = File(...), db: Session = Depends(get_db)):
+    """Attach a file to a specific task"""
     obj = db.get(Task, task_id)
     if not obj:
         raise HTTPException(status_code=404, detail="Task not found")
@@ -109,26 +101,27 @@ async def upload_file(task_id: int, file: UploadFile = File(...), db: Session =
         shutil.copyfileobj(file.file, buffer)
 
     obj.attachment = safe_name
-    db.add(AuditLog(action="upload", detail=f"Task ID {task_id} file {safe_name}"))
+    db.add(AuditLog(action="upload", detail=f"Task ID {task_id} uploaded file {safe_name}"))
     db.commit()
 
     return {"task_id": task_id, "filename": safe_name}
 
-
-# ==============================
-# 8️⃣ Emergency endpoint: Create database tables
-# ==============================
+# ================================================
+# 8️⃣ Database Initialization Endpoint (/create-db)
+# ================================================
 from app.models.user import User
+from app.models.otp import OtpModel
 from app.database import Base as DBBase, engine as DBEngine
 
-
 @app.get("/create-db")
 def create_database():
     """
-    🔧 Use this endpoint on Render once if tables fail to auto-create.
+    🔧 Create all database tables if they don't exist.
+    Run this once on Render or local after migrations.
     """
     try:
         DBBase.metadata.create_all(bind=DBEngine)
-        return {"ok": True, "message": "Database tables created successfully"}
+        Base.metadata.create_all(bind=engine)
+        return {"ok": True, "message": "✅ All database tables created successfully"}
     except Exception as e:
         return {"ok": False, "error": str(e)}