Skip to content

Commit 9aa8723

Browse files
authored
Merge pull request #7321 from blmaier/conda-forge-fix-argument-list
GNUmakefile: fix install error "argument list too long"
2 parents aaa2ebd + 22db84f commit 9aa8723

File tree

1 file changed

+19
-11
lines changed

1 file changed

+19
-11
lines changed

GNUmakefile

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ ifneq (,$(filter install, $(MAKECMDGOALS)))
88
override PROFILE:=release
99
endif
1010

11+
# Needed for the foreach loops to split each loop into a separate command
12+
define newline
13+
14+
15+
endef
16+
1117
PROFILE_CMD :=
1218
ifeq ($(PROFILE),release)
1319
PROFILE_CMD = --release
@@ -340,41 +346,43 @@ distclean: clean
340346
manpages: build-coreutils
341347
mkdir -p $(BUILDDIR)/man/
342348
$(foreach prog, $(INSTALLEES), \
343-
$(BUILDDIR)/coreutils manpage $(prog) > $(BUILDDIR)/man/$(PROG_PREFIX)$(prog).1; \
349+
$(BUILDDIR)/coreutils manpage $(prog) > $(BUILDDIR)/man/$(PROG_PREFIX)$(prog).1 $(newline) \
344350
)
345351

346352
completions: build-coreutils
347353
mkdir -p $(BUILDDIR)/completions/zsh $(BUILDDIR)/completions/bash $(BUILDDIR)/completions/fish
348354
$(foreach prog, $(INSTALLEES), \
349-
$(BUILDDIR)/coreutils completion $(prog) zsh > $(BUILDDIR)/completions/zsh/_$(PROG_PREFIX)$(prog); \
350-
$(BUILDDIR)/coreutils completion $(prog) bash > $(BUILDDIR)/completions/bash/$(PROG_PREFIX)$(prog); \
351-
$(BUILDDIR)/coreutils completion $(prog) fish > $(BUILDDIR)/completions/fish/$(PROG_PREFIX)$(prog).fish; \
355+
$(BUILDDIR)/coreutils completion $(prog) zsh > $(BUILDDIR)/completions/zsh/_$(PROG_PREFIX)$(prog) $(newline) \
356+
$(BUILDDIR)/coreutils completion $(prog) bash > $(BUILDDIR)/completions/bash/$(PROG_PREFIX)$(prog) $(newline) \
357+
$(BUILDDIR)/coreutils completion $(prog) fish > $(BUILDDIR)/completions/fish/$(PROG_PREFIX)$(prog).fish $(newline) \
352358
)
353359

354360
install: build manpages completions
355361
mkdir -p $(INSTALLDIR_BIN)
356362
ifeq (${MULTICALL}, y)
357363
$(INSTALL) $(BUILDDIR)/coreutils $(INSTALLDIR_BIN)/$(PROG_PREFIX)coreutils
358-
cd $(INSTALLDIR_BIN) && $(foreach prog, $(filter-out coreutils, $(INSTALLEES)), \
359-
ln -fs $(PROG_PREFIX)coreutils $(PROG_PREFIX)$(prog) &&) :
364+
$(foreach prog, $(filter-out coreutils, $(INSTALLEES)), \
365+
cd $(INSTALLDIR_BIN) && ln -fs $(PROG_PREFIX)coreutils $(PROG_PREFIX)$(prog) $(newline) \
366+
)
360367
$(if $(findstring test,$(INSTALLEES)), cd $(INSTALLDIR_BIN) && ln -fs $(PROG_PREFIX)coreutils $(PROG_PREFIX)[)
361368
else
362369
$(foreach prog, $(INSTALLEES), \
363-
$(INSTALL) $(BUILDDIR)/$(prog) $(INSTALLDIR_BIN)/$(PROG_PREFIX)$(prog);)
370+
$(INSTALL) $(BUILDDIR)/$(prog) $(INSTALLDIR_BIN)/$(PROG_PREFIX)$(prog) $(newline) \
371+
)
364372
$(if $(findstring test,$(INSTALLEES)), $(INSTALL) $(BUILDDIR)/test $(INSTALLDIR_BIN)/$(PROG_PREFIX)[)
365373
endif
366374
mkdir -p $(DESTDIR)$(DATAROOTDIR)/man/man1
367375
$(foreach prog, $(INSTALLEES), \
368-
$(INSTALL) $(BUILDDIR)/man/$(PROG_PREFIX)$(prog).1 $(DESTDIR)$(DATAROOTDIR)/man/man1/; \
376+
$(INSTALL) $(BUILDDIR)/man/$(PROG_PREFIX)$(prog).1 $(DESTDIR)$(DATAROOTDIR)/man/man1/ $(newline) \
369377
)
370378

371379
mkdir -p $(DESTDIR)$(DATAROOTDIR)/zsh/site-functions
372380
mkdir -p $(DESTDIR)$(DATAROOTDIR)/bash-completion/completions
373381
mkdir -p $(DESTDIR)$(DATAROOTDIR)/fish/vendor_completions.d
374382
$(foreach prog, $(INSTALLEES), \
375-
$(INSTALL) $(BUILDDIR)/completions/zsh/_$(PROG_PREFIX)$(prog) $(DESTDIR)$(DATAROOTDIR)/zsh/site-functions/; \
376-
$(INSTALL) $(BUILDDIR)/completions/bash/$(PROG_PREFIX)$(prog) $(DESTDIR)$(DATAROOTDIR)/bash-completion/completions/; \
377-
$(INSTALL) $(BUILDDIR)/completions/fish/$(PROG_PREFIX)$(prog).fish $(DESTDIR)$(DATAROOTDIR)/fish/vendor_completions.d/; \
383+
$(INSTALL) $(BUILDDIR)/completions/zsh/_$(PROG_PREFIX)$(prog) $(DESTDIR)$(DATAROOTDIR)/zsh/site-functions/ $(newline) \
384+
$(INSTALL) $(BUILDDIR)/completions/bash/$(PROG_PREFIX)$(prog) $(DESTDIR)$(DATAROOTDIR)/bash-completion/completions/ $(newline) \
385+
$(INSTALL) $(BUILDDIR)/completions/fish/$(PROG_PREFIX)$(prog).fish $(DESTDIR)$(DATAROOTDIR)/fish/vendor_completions.d/ $(newline) \
378386
)
379387

380388
uninstall:

0 commit comments

Comments
 (0)