Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: drop flake-utils, refactor #7368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bloxx12
Copy link

@bloxx12 bloxx12 commented Feb 27, 2025

  • Refactor the flake, updating deprecated things (devShell -> devShells.default)
  • drop flake-utils, since this is really not needed here and can be replaces by a few simple lines of nix code
  • use a systems input to specify the systems, since users can override that locally, which can be very convenient

I have tested basic functionality and it should function just the same as before.

@cakebaker cakebaker requested a review from RenjiSann February 27, 2025 10:46
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

export PATH=$PATH:''${CARGO_HOME:-~/.cargo}/bin
export PATH=$PATH:''${RUSTUP_HOME:-~/.rustup}/toolchains/$RUSTC_VERSION-x86_64-unknown-linux-gnu/bin/
'';
RUSTC_VERSION = "1.75";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take advantage of this PR to bump the rust version to the current MSRV

Suggested change
RUSTC_VERSION = "1.75";
RUSTC_VERSION = "1.79";

Copy link
Collaborator

@RenjiSann RenjiSann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactoring this. I'm no expert in Nix, and I'm happy to see it used and maintained.

The changes looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants