-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for findmnt
#210
base: main
Are you sure you want to change the base?
Conversation
Can you please run |
01071f2
to
2977baa
Compare
Yup. I guess that is the case. I'll feature gate this on linux only
|
there might be crate or equivalent for mac/unix. Maybe have a look before making this linux specific |
@sylvestre I see there are some alternatives present inside macOS like the mount and diskutil commands. But shouldn't they be implemented differently from the findmnt one? I am a bit confused here on what do I need to do further. |
path = "src/main.rs" | ||
|
||
[dependencies] | ||
tabled = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recently removed tabled
and so this will no longer work. And as the output currently looks quite different from the output of the original findmnt
, I think it is probably easier to do the output manually than trying to figure out how to do it with tabled
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Harshit933 I had started working on a findmnt
implementation as well before realizing you had this PR open, feel free to take the output code from here, that version doesn't use tabled
.
For now the output of
findmnt
is:Potential fix #23