The National Map (TNM) API Errors

[scottyhq]

Currently the sliderule 3DEP sampling notebook fails trying to sample 3DEP
https://coincident.readthedocs.io/en/stable/examples/sliderule.html#sample-3dep

The problem is actually that TNM API is down:
SlideRuleEarth/sliderule#457

There is a history of API reliability issues with this one
https://github.com/search?q=repo%3ASlideRuleEarth%2Fsliderule+TNM&type=issues

Which are not always reflected in the API 'status':
https://stats.uptimerobot.com/gxzRZFARLZ

[scottyhq]

Going to just add comments any time tests fail 😅

test_load_usgs_dem 

>           raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
E           requests.exceptions.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)

[scottyhq]

The load_usgs_dem function example in the docs fails regularly.
https://coincident.readthedocs.io/en/latest/examples/dem_and_lpc.html#dep-and-neon-overlapping-flights

da_usgs_dem = coincident.io.xarray.load_usgs_dem(aoi, usgs_project)

equivalent query string:

https://tnmaccess.nationalmap.gov/api/v1/products?datasets=Digital+Elevation+Model+%28DEM%29+1+meter&polygon=-102.49+39.675%2C+-102.49+39.685%2C+-102.505+39.685%2C+-102.505+39.675%2C+-102.49+39.675&prodFormats=GeoTIFF&outputFormat=JSON&max=200&offset=0

When things are working, this returns a (y: 1146x: 1317) array in a few seconds, but I'm seeing errors like these :(

{"error": "Your search was too broad. Please refine your search criteria for better results.", "showToast": true, "toastMessage": "Your search was too broad. Please refine your search criteria for better results.", "toastType": "warning"}

{errorMessage=[BadRequest] 'HTTPSConnectionPool(host='www.sciencebase.gov', port=443): Max retries exceeded with url

{"message": "Endpoint request timed out"}

If we keep this function we should surface errors from TNM, rather than catching all with ValueError: TNM API returned no products for the given AOI and dataset.

coincident/src/coincident/io/xarray.py

Lines 283 to 286 in 0df07e6

	tnm_api_items = query_tnm_api(polygon_string, tnmdataset=tnmdataset)
	if not tnm_api_items:
	msg_empty_tnm = "TNM API returned no products for the given AOI and dataset."
	raise ValueError(msg_empty_tnm)