Skip to content

Commit e1cb169

Browse files
Rename courseService
1 parent f67e279 commit e1cb169

File tree

5 files changed

+21
-19
lines changed

5 files changed

+21
-19
lines changed

backend/rest/courseRoutes.ts

+13-11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Router } from "express";
2-
import CourseService from "../services/implementations/courseService";
2+
import CourseUnitService from "../services/implementations/courseUnitService";
33
import { getErrorMessage } from "../utilities/errorUtils";
44
import {
55
createCourseUnitDtoValidator,
@@ -8,14 +8,14 @@ import {
88
import { isAuthorizedByRole } from "../middlewares/auth";
99

1010
const courseRouter: Router = Router();
11-
const courseService: CourseService = new CourseService();
11+
const courseUnitService: CourseUnitService = new CourseUnitService();
1212

1313
courseRouter.get(
1414
"/",
15-
isAuthorizedByRole(new Set(["Administrator"])),
15+
isAuthorizedByRole(new Set(["Administrator", "Facilitator", "Learner"])),
1616
async (req, res) => {
1717
try {
18-
const courses = await courseService.getCourseUnits();
18+
const courses = await courseUnitService.getCourseUnits();
1919
res.status(200).json(courses);
2020
} catch (e: unknown) {
2121
res.status(500).send(getErrorMessage(e));
@@ -29,7 +29,7 @@ courseRouter.post(
2929
createCourseUnitDtoValidator,
3030
async (req, res) => {
3131
try {
32-
const newCourse = await courseService.createCourseUnit({
32+
const newCourse = await courseUnitService.createCourseUnit({
3333
title: req.body.title,
3434
});
3535
res.status(201).json(newCourse);
@@ -40,13 +40,13 @@ courseRouter.post(
4040
);
4141

4242
courseRouter.put(
43-
"/:id",
43+
"/:unitId",
4444
isAuthorizedByRole(new Set(["Administrator"])),
4545
updateCourseUnitDtoValidator,
4646
async (req, res) => {
47-
const { id } = req.params;
47+
const { unitId } = req.params;
4848
try {
49-
const course = await courseService.updateCourseUnit(id, {
49+
const course = await courseUnitService.updateCourseUnit(unitId, {
5050
title: req.body.title,
5151
});
5252
res.status(200).json(course);
@@ -57,12 +57,14 @@ courseRouter.put(
5757
);
5858

5959
courseRouter.delete(
60-
"/:id",
60+
"/:unitId",
6161
isAuthorizedByRole(new Set(["Administrator"])),
6262
async (req, res) => {
63-
const { id } = req.params;
63+
const { unitId } = req.params;
6464
try {
65-
const deletedCourseUnitId = await courseService.deleteCourseUnit(id);
65+
const deletedCourseUnitId = await courseUnitService.deleteCourseUnit(
66+
unitId,
67+
);
6668
res.status(200).json({ id: deletedCourseUnitId });
6769
} catch (e: unknown) {
6870
res.status(500).send(getErrorMessage(e));

backend/server.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ app.use("/entities", entityRouter);
7777
app.use("/users", userRouter);
7878
app.use("/help-request", helpRequestRouter);
7979
app.use("/notifications", notificationRouter);
80-
app.use("/courses", courseRouter);
80+
app.use("/course", courseRouter);
8181
app.use("/api-docs", swaggerUi.serve, swaggerUi.setup(swaggerDocument));
8282
app.set("io", io);
8383

backend/services/implementations/courseService.ts renamed to backend/services/implementations/courseUnitService.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ import {
55
UpdateCourseUnitDTO,
66
} from "../../types/courseTypes";
77
import logger from "../../utilities/logger";
8-
import ICourseService from "../interfaces/courseService";
8+
import ICourseUnitService from "../interfaces/courseUnitService";
99
import MgCourseUnit, { CourseUnit } from "../../models/courseunit.mgmodel";
1010
import { getErrorMessage } from "../../utilities/errorUtils";
1111

1212
const Logger = logger(__filename);
1313

14-
class CourseService implements ICourseService {
14+
class CourseUnitService implements ICourseUnitService {
1515
async getCourseUnits(): Promise<Array<CourseUnitDTO>> {
1616
try {
1717
const courseUnits: Array<CourseUnit> = await MgCourseUnit.find().sort(
@@ -105,4 +105,4 @@ class CourseService implements ICourseService {
105105
}
106106
}
107107

108-
export default CourseService;
108+
export default CourseUnitService;

backend/services/implementations/userService.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ class UserService implements IUserService {
254254
await firebaseAdmin.auth().deleteUser(deletedUser.authId);
255255
} catch (error) {
256256
// rollback user deletion in MongoDB
257-
const { id, ...rest } = deletedUser.toJSON();
257+
const { id, ...rest } = deletedUser.toObject();
258258
try {
259259
await MgUser.create(rest);
260260
} catch (mongoDbError: unknown) {
@@ -292,7 +292,7 @@ class UserService implements IUserService {
292292
await firebaseAdmin.auth().deleteUser(firebaseUser.uid);
293293
} catch (error) {
294294
// rollback user deletion in MongoDB
295-
const { id, ...rest } = deletedUser.toJSON();
295+
const { id, ...rest } = deletedUser.toObject();
296296
try {
297297
await MgUser.create(rest);
298298
} catch (mongoDbError: unknown) {

backend/services/interfaces/courseService.ts renamed to backend/services/interfaces/courseUnitService.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
UpdateCourseUnitDTO,
55
} from "../../types/courseTypes";
66

7-
interface ICourseService {
7+
interface ICourseUnitService {
88
/**
99
* Returns all courseunits
1010
* @throwsError if courses were not successfully fetched
@@ -38,4 +38,4 @@ interface ICourseService {
3838
deleteCourseUnit(id: string): Promise<string>;
3939
}
4040

41-
export default ICourseService;
41+
export default ICourseUnitService;

0 commit comments

Comments
 (0)