Skip to content

Commit 9cd80f5

Browse files
committed
Fix linting errors
1 parent 01568e4 commit 9cd80f5

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

backend/typescript/rest/authRoutes.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,11 @@ authRouter.post("/invite-user", inviteUserDtoValidator, async (req, res) => {
172172
return;
173173
}
174174

175-
await authService.sendInviteEmail(user.firstName + " " + user.lastName, req.body.email, String(user.role));
175+
await authService.sendInviteEmail(
176+
`${user.firstName} ${user.lastName}`,
177+
req.body.email,
178+
String(user.role),
179+
);
176180
if (user.status === UserStatus.INVITED) {
177181
res
178182
.status(204)

backend/typescript/services/implementations/authService.ts

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import * as firebaseAdmin from "firebase-admin";
22

3+
import fs from "fs";
34
import IAuthService from "../interfaces/authService";
45
import IEmailService from "../interfaces/emailService";
56
import IUserService from "../interfaces/userService";
67
import { AuthDTO, Role, Token, ResponseSuccessDTO } from "../../types";
78
import { getErrorMessage } from "../../utilities/errorUtils";
89
import FirebaseRestClient from "../../utilities/firebaseRestClient";
9-
import fs from "fs";
1010
import logger from "../../utilities/logger";
1111

1212
const Logger = logger(__filename);
@@ -119,7 +119,11 @@ class AuthService implements IAuthService {
119119
}
120120
}
121121

122-
async sendInviteEmail(name: string, email: string, role: string): Promise<void> {
122+
async sendInviteEmail(
123+
name: string,
124+
email: string,
125+
role: string,
126+
): Promise<void> {
123127
if (!this.emailService) {
124128
const errorMessage =
125129
"Attempted to call sendEmailVerificationLink but this instance of AuthService does not have an EmailService instance";
@@ -135,11 +139,15 @@ class AuthService implements IAuthService {
135139
roleString += role;
136140

137141
const signInLink = await this.generateSignInLink(email);
138-
let emailTemplate = fs.readFileSync(__dirname + "/../../html-templates/email.html", "utf8");
139-
const renderedEmailTemplate = emailTemplate.replace('{{ name }}', name)
140-
.replace('{{ roleString }}', roleString)
141-
.replace('{{ signInLink }}', signInLink)
142-
.replace('{{ signInLink }}', signInLink); // necessary for second occurrence
142+
const emailTemplate = fs.readFileSync(
143+
`${__dirname}/../../html-templates/email.html`,
144+
"utf8",
145+
);
146+
const renderedEmailTemplate = emailTemplate
147+
.replace("{{ name }}", name)
148+
.replace("{{ roleString }}", roleString)
149+
.replace("{{ signInLink }}", signInLink)
150+
.replace("{{ signInLink }}", signInLink); // necessary for second occurrence
143151
this.emailService.sendEmail(
144152
email,
145153
"Welcome to the Oakville and Milton Humane Society!",

0 commit comments

Comments
 (0)