Closed
Conversation
matthewd-so
reviewed
Oct 14, 2025
| teamRole: TeamRole; | ||
| }; | ||
| // same as above but without id | ||
| // frontend -> backend |
Contributor
There was a problem hiding this comment.
Great comments, really shows me that you understand the database, model, and types.
matthewd-so
reviewed
Oct 14, 2025
| @@ -0,0 +1,23 @@ | |||
| import { DataType } from "sequelize-typescript"; | |||
Contributor
There was a problem hiding this comment.
These files aren't part of the onboarding. Just pull from main next time :)
Contributor
|
Your HTTP request screenshots look good as well. Just fix your conflicts and this should be good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Onboarding Task
Implementation description
Steps to test
docker compose up -dnode migrate uphttp://localhost:3000/team-membersPostman Test Cases:
