addressing comments

Author: matia-lee

backend/app/schemas/volunteer_data.py

@@ -55,7 +55,7 @@ class VolunteerDataResponse(BaseModel):
     """
 
     id: UUID
-    user_id: UUID
+    user_id: Optional[UUID]
     experience: Optional[str]
     references_json: Optional[str]
     additional_comments: Optional[str]

backend/app/services/implementations/volunteer_data_service.py

@@ -24,17 +24,17 @@ async def create_volunteer_data(
         self, volunteer_data: VolunteerDataCreateRequest
     ) -> VolunteerDataResponse:
         try:
-            # Check if volunteer data already exists for this user
-            existing_data = (
-                self.db.query(VolunteerData)
-                .filter(VolunteerData.user_id == volunteer_data.user_id)
-                .first()
-            )
-            if existing_data:
-                raise HTTPException(
-                    status_code=409,
-                    detail="Volunteer data already exists for this user"
+            if volunteer_data.user_id is not None:
+                existing_data = (
+                    self.db.query(VolunteerData)
+                    .filter(VolunteerData.user_id == volunteer_data.user_id)
+                    .first()
                 )
+                if existing_data:
+                    raise HTTPException(
+                        status_code=409,
+                        detail="Volunteer data already exists for this user"
+                    )
 
             # Create new volunteer data entry
             db_volunteer_data = VolunteerData(

backend/migrations/versions/e71f29bbfe31_make_user_id_nullable_in_volunteer_data.py

@@ -6,6 +6,7 @@
 
 """
 from typing import Sequence, Union
+from alembic import op
 
 # revision identifiers, used by Alembic.
 revision: str = 'e71f29bbfe31'
@@ -15,8 +16,16 @@
 
 
 def upgrade() -> None:
-    pass
+    # Make user_id nullable to allow public submissions without user accounts
+    op.alter_column('volunteer_data', 'user_id', nullable=True)
+    
+    # Drop the unique constraint since we'll have multiple NULL values
+    op.drop_constraint('uq_volunteer_data_user_id', 'volunteer_data', type_='unique')
 
 
 def downgrade() -> None:
-    pass
+    # Recreate the unique constraint
+    op.create_unique_constraint('uq_volunteer_data_user_id', 'volunteer_data', ['user_id'])
+    
+    # Make user_id non-nullable again
+    op.alter_column('volunteer_data', 'user_id', nullable=False)